pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Heikki Linnakangas <heikki.linnakangas@iki.fi>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: Try to unbreak injection-fault tests in the buildfarm
Date: Fri, 15 Mar 2024 13:22:25 +0000
Message-ID: <E1rl7Vx-003vzA-AW@gemulon.postgresql.org> (raw)

Try to unbreak injection-fault tests in the buildfarm

The buildfarm script attempts to run all tests marked as
NO_INSTALLCHECK under src/test/modules without paying attention to
whether they are enabled or disabled in the parent Makefile. That
hasn't been a problem so far, because all the tests marked with
NO_INSTALLCHECK ran unconditionally in "make check". But commit
e2e3b8ae9e changed that: the injection fault tests are marked as
NO_INSTALLCHECK, and also depend on --enable-injection-points.

Try to work around that by ensuring that "make check" does nothing in
the those subdirectories. We can hopefully get rid of this hack soon,
after fixing the buildfarm client, or by switching to meson.

Discussion: https://www.postgresql.org/message-id/8e4cf596-dd70-432e-9068-16466ed596ed%40iki.fi

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/85f65d7a26fc24ad9711aa5f1ca7e20ea3ea77e6

Modified Files
--------------
src/test/modules/gin/Makefile              | 12 ++++++++++++
src/test/modules/injection_points/Makefile | 12 ++++++++++++
2 files changed, 24 insertions(+)



view thread (2+ messages)

Message-ID: <E1rl7Vx-003vzA-AW@gemulon.postgresql.org>
Permalink:  ../E1rl7Vx-003vzA-AW@gemulon.postgresql.org/
Also on:    postgresql.org/message-id/E1rl7Vx-003vzA-AW@gemulon.postgresql.org

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-committers@postgresql.org
  Cc: heikki.linnakangas@iki.fi, pgsql-committers@lists.postgresql.org
  Subject: Re: pgsql: Try to unbreak injection-fault tests in the buildfarm
  In-Reply-To: <E1rl7Vx-003vzA-AW@gemulon.postgresql.org>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox