From: Peter Eisentraut <peter@eisentraut.org>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: Separate equalRowTypes() from equalTupleDescs()
Date: Sun, 17 Mar 2024 05:05:24 +0000
Message-ID: <E1rlii3-004E7X-QO@gemulon.postgresql.org> (raw)
Separate equalRowTypes() from equalTupleDescs()
This introduces a new function equalRowTypes() that is effectively a
subset of equalTupleDescs() but only compares the number of attributes
and attribute name, type, typmod, and collation. This is enough for
most existing uses of equalTupleDescs(), which are changed to use the
new function. The only remaining callers of equalTupleDescs() are
those that really want to check the full tuple descriptor as such,
without concern about record or row or record type semantics.
The existing function hashTupleDesc() is renamed to hashRowType(),
because it now corresponds more to equalRowTypes().
The purpose of this change is to be clearer about the semantics of the
equality asked for by each caller. (At least one caller had a comment
that questioned whether equalTupleDescs() was too restrictive.) For
example, 4f622503d6d removed attstattarget from the tuple descriptor
structure. It was not fully clear at the time how this should affect
equalTupleDescs(). Now the answer is clear: By their own definitions,
equalRowTypes() does not care, and equalTupleDescs() just compares
whatever is in the tuple descriptor but does not care why it is in
there.
Reviewed-by: Tomas Vondra <tomas.vondra@enterprisedb.com>
Discussion: https://www.postgresql.org/message-id/flat/f656d6d9-6660-4518-a006-2f65cafbebd1%40eisentraut.org
Branch
------
master
Details
-------
https://git.postgresql.org/pg/commitdiff/20e58105badff383bd43f0b97e532771768f94df
Modified Files
--------------
src/backend/access/common/tupdesc.c | 72 ++++++++++++++++++++++++++++++-------
src/backend/catalog/pg_proc.c | 2 +-
src/backend/commands/analyze.c | 4 +--
src/backend/commands/view.c | 14 ++++----
src/backend/utils/cache/plancache.c | 5 ++-
src/backend/utils/cache/typcache.c | 10 +++---
src/include/access/tupdesc.h | 4 +--
7 files changed, 79 insertions(+), 32 deletions(-)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-committers@postgresql.org
Cc: peter@eisentraut.org, pgsql-committers@lists.postgresql.org
Subject: Re: pgsql: Separate equalRowTypes() from equalTupleDescs()
In-Reply-To: <E1rlii3-004E7X-QO@gemulon.postgresql.org>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox