pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  

help / color / mirror / Atom feed
From: Jeff Davis <jdavis@postgresql.org>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: Address more review comments on commit 2d819a08a1.
Date: Mon, 18 Mar 2024 18:58:38 +0000
Message-ID: <E1rmIBy-004UCS-1V@gemulon.postgresql.org> (raw)

Address more review comments on commit 2d819a08a1.

Based on comments from Peter Eisentraut.

 * Document CREATE DATABASE ... BUILTIN_LOCALE.
 * Determine required encoding based on locale name for CREATE
   COLLATION. Use -1 for "C" (requires catversion bump).
 * initdb output fixups.
 * Make ctype_is_c a constant true for now.
 * Fixups to ICU 010_create_database.pl test.

Discussion: https://postgr.es/m/4135cf11-206d-40ed-96c0-9363c1232379@eisentraut.org

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/846311051e8fdca4c9db83b2b09425759a8b102d

Modified Files
--------------
doc/src/sgml/ref/create_database.sgml | 18 ++++++++++++++++++
src/backend/commands/collationcmds.c  |  2 +-
src/backend/utils/adt/pg_locale.c     | 28 +++++++++++++++++++++-------
src/bin/initdb/initdb.c               |  7 ++++---
src/bin/initdb/t/001_initdb.pl        |  2 +-
src/include/catalog/catversion.h      |  2 +-
src/include/utils/pg_locale.h         |  1 +
src/test/icu/t/010_database.pl        | 12 +++++++++++-
8 files changed, 58 insertions(+), 14 deletions(-)



Message-ID: <E1rmIBy-004UCS-1V@gemulon.postgresql.org>
Permalink:  ../E1rmIBy-004UCS-1V@gemulon.postgresql.org/
Also on:    postgresql.org/message-id/E1rmIBy-004UCS-1V@gemulon.postgresql.org

 · 

reply
Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-committers@postgresql.org
  Cc: jdavis@postgresql.org, pgsql-committers@lists.postgresql.org
  Subject: Re: pgsql: Address more review comments on commit 2d819a08a1.
  In-Reply-To: <E1rmIBy-004UCS-1V@gemulon.postgresql.org>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox