From: Daniel Gustafsson <dgustafsson@postgresql.org>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: pg_upgrade: run all data type checks per connection
Date: Tue, 19 Mar 2024 12:38:56 +0000
Message-ID: <E1rmYk4-004axM-1q@gemulon.postgresql.org> (raw)
pg_upgrade: run all data type checks per connection
The checks for data type usage were each connecting to all databases
in the cluster and running their query. On clusters which have a lot
of databases this can become unnecessarily expensive. This moves the
checks to run in a single connection instead to minimize setup and
teardown overhead.
Reviewed-by: Nathan Bossart <nathandbossart@gmail.com>
Reviewed-by: Justin Pryzby <pryzby@telsasoft.com>
Reviewed-by: Peter Eisentraut <peter@eisentraut.org>
Discussion: https://postgr.es/m/BB4C76F-D416-4F9F-949E-DBE950D37787@yesql.se
Branch
------
master
Details
-------
https://git.postgresql.org/pg/commitdiff/347758b1206364e3bec5ad6cd649b4ba9fe1be7b
Modified Files
--------------
src/bin/pg_upgrade/check.c | 749 ++++++++++++++++++++++++++--------------
src/bin/pg_upgrade/pg_upgrade.h | 13 +-
src/bin/pg_upgrade/version.c | 265 +-------------
3 files changed, 506 insertions(+), 521 deletions(-)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-committers@postgresql.org
Cc: dgustafsson@postgresql.org, pgsql-committers@lists.postgresql.org
Subject: Re: pgsql: pg_upgrade: run all data type checks per connection
In-Reply-To: <E1rmYk4-004axM-1q@gemulon.postgresql.org>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox