From: Peter Eisentraut <peter@eisentraut.org>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: Remove custom _jumbleRangeTblEntry()
Date: Fri, 22 Mar 2024 06:27:56 +0000
Message-ID: <E1rnYNg-0053Ow-7H@gemulon.postgresql.org> (raw)
Remove custom _jumbleRangeTblEntry()
This is part of an effort to reduce the number of special cases in the
automatically generated node support functions.
This patch removes _jumbleRangeTblEntry() and instead adds per-field
query_jumble_ignore annotations to match the behavior of the previous
custom code. The pg_stat_statements test suite has some coverage of
this. It gets rid of the switch on rtekind; this should be
technically correct, since we do the equal and copy functions like
this also.
The list of fields to jumble has been checked and is considered
correct as of 8b29a119fd.
Reviewed-by: Andrew Dunstan <andrew@dunslane.net>
Discussion: https://www.postgresql.org/message-id/flat/4b27fc50-8cd6-46f5-ab20-88dbaadca645@eisentraut.org
Branch
------
master
Details
-------
https://git.postgresql.org/pg/commitdiff/367c989cd8405663bb9a35ec1aa4f79b673a55ff
Modified Files
--------------
src/backend/nodes/queryjumblefuncs.c | 49 ------------------------------------
src/include/nodes/parsenodes.h | 40 ++++++++++++++---------------
2 files changed, 20 insertions(+), 69 deletions(-)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-committers@postgresql.org
Cc: peter@eisentraut.org, pgsql-committers@lists.postgresql.org
Subject: Re: pgsql: Remove custom _jumbleRangeTblEntry()
In-Reply-To: <E1rnYNg-0053Ow-7H@gemulon.postgresql.org>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox