pg.ddx.io pgsql-committers@postgresql.org mailing list archive
help / color / mirror / Atom feedpgsql: Fix GUC's reports of assign_hook failure to always include the
3+ messages / 2 participants
[nested] [flat]
* pgsql: Fix GUC's reports of assign_hook failure to always include the
@ 2009-04-02 03:51 Tom Lane <tgl@postgresql.org>
0 siblings, 0 replies; 3+ messages in thread
From: tgl@postgresql.org @ 2009-04-02 03:51 UTC (permalink / raw)
To: pgsql-committers
Log Message:
-----------
Fix GUC's reports of assign_hook failure to always include the parameter value
we failed to assign, even in "can't happen" cases. Motivated by wondering
what's going on in a recent trouble report where "failed to commit" did
happen.
Modified Files:
--------------
pgsql/src/backend/utils/misc:
guc.c (r1.497 -> r1.498)
(http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/src/backend/utils/misc/guc.c?r1=1.497&r2=1.498)
^ permalink raw reply [nested|flat] 3+ messages in thread
* pgsql: Fix GUC's reports of assign_hook failure to always include the
@ 2009-04-02 03:51 Tom Lane <tgl@postgresql.org>
0 siblings, 0 replies; 3+ messages in thread
From: tgl@postgresql.org @ 2009-04-02 03:51 UTC (permalink / raw)
To: pgsql-committers
Log Message:
-----------
Fix GUC's reports of assign_hook failure to always include the parameter value
we failed to assign, even in "can't happen" cases. Motivated by wondering
what's going on in a recent trouble report where "failed to commit" did
happen.
Tags:
----
REL8_3_STABLE
Modified Files:
--------------
pgsql/src/backend/utils/misc:
guc.c (r1.432.2.2 -> r1.432.2.3)
(http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/src/backend/utils/misc/guc.c?r1=1.432.2.2&r2=1.43...)
^ permalink raw reply [nested|flat] 3+ messages in thread
* pgsql: Remove custom _jumbleRangeTblEntry()
@ 2024-03-22 06:27 Peter Eisentraut <peter@eisentraut.org>
0 siblings, 0 replies; 3+ messages in thread
From: Peter Eisentraut @ 2024-03-22 06:27 UTC (permalink / raw)
To: pgsql-committers@lists.postgresql.org
Remove custom _jumbleRangeTblEntry()
This is part of an effort to reduce the number of special cases in the
automatically generated node support functions.
This patch removes _jumbleRangeTblEntry() and instead adds per-field
query_jumble_ignore annotations to match the behavior of the previous
custom code. The pg_stat_statements test suite has some coverage of
this. It gets rid of the switch on rtekind; this should be
technically correct, since we do the equal and copy functions like
this also.
The list of fields to jumble has been checked and is considered
correct as of 8b29a119fd.
Reviewed-by: Andrew Dunstan <andrew@dunslane.net>
Discussion: https://www.postgresql.org/message-id/flat/4b27fc50-8cd6-46f5-ab20-88dbaadca645@eisentraut.org
Branch
------
master
Details
-------
https://git.postgresql.org/pg/commitdiff/367c989cd8405663bb9a35ec1aa4f79b673a55ff
Modified Files
--------------
src/backend/nodes/queryjumblefuncs.c | 49 ------------------------------------
src/include/nodes/parsenodes.h | 40 ++++++++++++++---------------
2 files changed, 20 insertions(+), 69 deletions(-)
^ permalink raw reply [nested|flat] 3+ messages in thread
end of thread, other threads:[~2024-03-22 06:27 UTC | newest]
Thread overview: 3+ messages (download: mbox mbox.gz follow: Atom feed)
-- links below jump to the message on this page --
2009-04-02 03:51 pgsql: Fix GUC's reports of assign_hook failure to always include the Tom Lane <tgl@postgresql.org>
2009-04-02 03:51 pgsql: Fix GUC's reports of assign_hook failure to always include the Tom Lane <tgl@postgresql.org>
2024-03-22 06:27 pgsql: Remove custom _jumbleRangeTblEntry() Peter Eisentraut <peter@eisentraut.org>
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox