pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Daniel Gustafsson <dgustafsson@postgresql.org>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: ecpg: Fix return code for overflow in numeric conversion
Date: Mon, 25 Mar 2024 13:21:25 +0000
Message-ID: <E1rokGT-005ZqW-HG@gemulon.postgresql.org> (raw)

ecpg: Fix return code for overflow in numeric conversion

The decimal conversion functions dectoint and dectolong are documented
to return ECPG_INFORMIX_NUM_OVERFLOW in case of overflows, but always
returned -1 on all errors due to incorrectly checking the returnvalue
from the PGTYPES* functions.

Author: Aidar Imamov <a.imamov@postgrespro.ru>
Discussion: https://postgr.es/m/54d2b53327516d9454daa5fb2f893bdc@postgrespro.ru

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/b2d6b4c728a282f9bbe9ff4fac02a872bef074dd

Modified Files
--------------
src/interfaces/ecpg/compatlib/informix.c                     | 10 ++++++++--
.../ecpg/test/expected/compat_informix-dec_test.stdout       | 12 ++++++------
2 files changed, 14 insertions(+), 8 deletions(-)



view thread (2+ messages)

Message-ID: <E1rokGT-005ZqW-HG@gemulon.postgresql.org>
Permalink:  ../E1rokGT-005ZqW-HG@gemulon.postgresql.org/
Also on:    postgresql.org/message-id/E1rokGT-005ZqW-HG@gemulon.postgresql.org

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-committers@postgresql.org
  Cc: dgustafsson@postgresql.org, pgsql-committers@lists.postgresql.org
  Subject: Re: pgsql: ecpg: Fix return code for overflow in numeric conversion
  In-Reply-To: <E1rokGT-005ZqW-HG@gemulon.postgresql.org>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox