pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Tom Lane <tgl@sss.pgh.pa.us>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: Refactor predicate_{implied,refuted}_by_simple_clause.
Date: Mon, 25 Mar 2024 21:45:25 +0000
Message-ID: <E1ros8D-005dr2-D4@gemulon.postgresql.org> (raw)

Refactor predicate_{implied,refuted}_by_simple_clause.

Put the node-type-dependent operations into switches on nodeTag.
This should ease addition of new proof rules for other expression
node types.  There is no functional change, although some tests
are made in a different order than before.

Also, add a couple of new cross-checks in test_predtest.c.

James Coleman (part of a larger patch series)

Discussion: https://postgr.es/m/CAAaqYe8Bo4bf_i6qKj8KBsmHMYXhe3Xt6vOe3OBQnOaf3_XBWg@mail.gmail.com

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/c7076ba6ad1c2dc2ed50496b7ec71daebfe5327c

Modified Files
--------------
src/backend/optimizer/util/predtest.c          | 365 ++++++++++++++++---------
src/test/modules/test_predtest/test_predtest.c |  29 ++
2 files changed, 258 insertions(+), 136 deletions(-)



view thread (2+ messages)

Message-ID: <E1ros8D-005dr2-D4@gemulon.postgresql.org>
Permalink:  ../E1ros8D-005dr2-D4@gemulon.postgresql.org/
Also on:    postgresql.org/message-id/E1ros8D-005dr2-D4@gemulon.postgresql.org

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-committers@postgresql.org
  Cc: tgl@sss.pgh.pa.us, pgsql-committers@lists.postgresql.org
  Subject: Re: pgsql: Refactor predicate_{implied,refuted}_by_simple_clause.
  In-Reply-To: <E1ros8D-005dr2-D4@gemulon.postgresql.org>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox