pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Tom Lane <tgl@sss.pgh.pa.us>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: Remove some redundant set_cheapest() calls.
Date: Tue, 26 Mar 2024 20:02:54 +0000
Message-ID: <E1rpD0Y-005p09-Cb@gemulon.postgresql.org> (raw)

Remove some redundant set_cheapest() calls.

Commit e2fa76d80 centralized the responsibility for doing
set_cheapest() for a baserel, but these functions added later
seemingly didn't get the memo.  There's no apparent reason why
we need the cheapest path for these relation types to be available
any sooner than it is for other base relation types, so delete the
duplicate calls.  Doesn't save much since there's only one path
in these cases, but it might improve clarity.

Richard Guo

Discussion: https://postgr.es/m/CAMbWs4-KFEU_fDuJPNCOkUu3rwvZvKBEytkd9VrM4kH4-2h1CQ@mail.gmail.com

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/9d00cf47722a5d2876fc5c7727a395c0348dd304

Modified Files
--------------
src/backend/optimizer/path/allpaths.c | 6 ------
1 file changed, 6 deletions(-)



view thread (2+ messages)

Message-ID: <E1rpD0Y-005p09-Cb@gemulon.postgresql.org>
Permalink:  ../E1rpD0Y-005p09-Cb@gemulon.postgresql.org/
Also on:    postgresql.org/message-id/E1rpD0Y-005p09-Cb@gemulon.postgresql.org

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-committers@postgresql.org
  Cc: tgl@sss.pgh.pa.us, pgsql-committers@lists.postgresql.org
  Subject: Re: pgsql: Remove some redundant set_cheapest() calls.
  In-Reply-To: <E1rpD0Y-005p09-Cb@gemulon.postgresql.org>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox