pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  

help / color / mirror / Atom feed

From: Alvaro Herrera <alvherre@alvh.no-ip.org>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: ALTER TABLE: rework determination of access method ID
Date: Thu, 28 Mar 2024 15:52:08 +0000
Message-ID: <E1rps2x-006BNM-RG@gemulon.postgresql.org> (raw)

ALTER TABLE: rework determination of access method ID

Avoid setting an access method OID for relation kinds that don't take
one.  Code review for new feature added in 374c7a229042.

Author: Justin Pryzby <pryzby@telsasoft.com>
Reported-by: Alexander Lakhin <exclusion@gmail.com>
Discussion: https://postgr.es/m/e5516ac1-5264-c3c0-d822-9e6f614ea93b@gmail.com

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/e2395cdbe83adc50ac03dd17474ee88c5a97359a

Modified Files
--------------
src/backend/commands/tablecmds.c        | 26 +++++++++++++++-----------
src/test/regress/expected/create_am.out |  3 +++
src/test/regress/sql/create_am.sql      |  3 +++
3 files changed, 21 insertions(+), 11 deletions(-)

Message-ID: <E1rps2x-006BNM-RG@gemulon.postgresql.org>
Permalink:  ../E1rps2x-006BNM-RG@gemulon.postgresql.org/
Also on:    postgresql.org/message-id/E1rps2x-006BNM-RG@gemulon.postgresql.org

copy link · copy postgr.es

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-committers@postgresql.org
  Cc: alvherre@alvh.no-ip.org, pgsql-committers@lists.postgresql.org
  Subject: Re: pgsql: ALTER TABLE: rework determination of access method ID
  In-Reply-To: <E1rps2x-006BNM-RG@gemulon.postgresql.org>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox