pg.ddx.io pgsql-committers@postgresql.org mailing list archivehelp / color / mirror / Atom feed
pgsql: Avoid "unused variable" warning on non-USE_SSL_ENGINE platforms. 6+ messages / 1 participants [nested] [flat]
* pgsql: Avoid "unused variable" warning on non-USE_SSL_ENGINE platforms. @ 2024-04-01 23:01 Tom Lane <tgl@sss.pgh.pa.us> 0 siblings, 0 replies; 6+ messages in thread From: Tom Lane @ 2024-04-01 23:01 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Avoid "unused variable" warning on non-USE_SSL_ENGINE platforms. If we are building with openssl but USE_SSL_ENGINE didn't get set, initialize_SSL's variable "pkey" is declared but used nowhere. Apparently this combination hasn't been exercised in the buildfarm before now, because I've not seen this warning before, even though the code has been like this a long time. Move the declaration to silence the warning (and remove its useless initialization). Per buildfarm member sawshark. Back-patch to all supported branches. Branch ------ REL_13_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/c62b55cf39a5b1d751151c0c3b9fac4cf658d79c Modified Files -------------- src/interfaces/libpq/fe-secure-openssl.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) ^ permalink raw reply [nested|flat] 6+ messages in thread
* pgsql: Avoid "unused variable" warning on non-USE_SSL_ENGINE platforms. @ 2024-04-01 23:01 Tom Lane <tgl@sss.pgh.pa.us> 0 siblings, 0 replies; 6+ messages in thread From: Tom Lane @ 2024-04-01 23:01 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Avoid "unused variable" warning on non-USE_SSL_ENGINE platforms. If we are building with openssl but USE_SSL_ENGINE didn't get set, initialize_SSL's variable "pkey" is declared but used nowhere. Apparently this combination hasn't been exercised in the buildfarm before now, because I've not seen this warning before, even though the code has been like this a long time. Move the declaration to silence the warning (and remove its useless initialization). Per buildfarm member sawshark. Back-patch to all supported branches. Branch ------ REL_14_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/0de5274f59c9d84d803d7f3dc75577d8aa6e56b8 Modified Files -------------- src/interfaces/libpq/fe-secure-openssl.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) ^ permalink raw reply [nested|flat] 6+ messages in thread
* pgsql: Avoid "unused variable" warning on non-USE_SSL_ENGINE platforms. @ 2024-04-01 23:01 Tom Lane <tgl@sss.pgh.pa.us> 0 siblings, 0 replies; 6+ messages in thread From: Tom Lane @ 2024-04-01 23:01 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Avoid "unused variable" warning on non-USE_SSL_ENGINE platforms. If we are building with openssl but USE_SSL_ENGINE didn't get set, initialize_SSL's variable "pkey" is declared but used nowhere. Apparently this combination hasn't been exercised in the buildfarm before now, because I've not seen this warning before, even though the code has been like this a long time. Move the declaration to silence the warning (and remove its useless initialization). Per buildfarm member sawshark. Back-patch to all supported branches. Branch ------ REL_12_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/8f8511d4770868ff928ceded9d83c6eee14cce96 Modified Files -------------- src/interfaces/libpq/fe-secure-openssl.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) ^ permalink raw reply [nested|flat] 6+ messages in thread
* pgsql: Avoid "unused variable" warning on non-USE_SSL_ENGINE platforms. @ 2024-04-01 23:01 Tom Lane <tgl@sss.pgh.pa.us> 0 siblings, 0 replies; 6+ messages in thread From: Tom Lane @ 2024-04-01 23:01 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Avoid "unused variable" warning on non-USE_SSL_ENGINE platforms. If we are building with openssl but USE_SSL_ENGINE didn't get set, initialize_SSL's variable "pkey" is declared but used nowhere. Apparently this combination hasn't been exercised in the buildfarm before now, because I've not seen this warning before, even though the code has been like this a long time. Move the declaration to silence the warning (and remove its useless initialization). Per buildfarm member sawshark. Back-patch to all supported branches. Branch ------ master Details ------- https://git.postgresql.org/pg/commitdiff/3622c8084643cc05bc8f28d0b238615c845eae14 Modified Files -------------- src/interfaces/libpq/fe-secure-openssl.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) ^ permalink raw reply [nested|flat] 6+ messages in thread
* pgsql: Avoid "unused variable" warning on non-USE_SSL_ENGINE platforms. @ 2024-04-01 23:01 Tom Lane <tgl@sss.pgh.pa.us> 0 siblings, 0 replies; 6+ messages in thread From: Tom Lane @ 2024-04-01 23:01 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Avoid "unused variable" warning on non-USE_SSL_ENGINE platforms. If we are building with openssl but USE_SSL_ENGINE didn't get set, initialize_SSL's variable "pkey" is declared but used nowhere. Apparently this combination hasn't been exercised in the buildfarm before now, because I've not seen this warning before, even though the code has been like this a long time. Move the declaration to silence the warning (and remove its useless initialization). Per buildfarm member sawshark. Back-patch to all supported branches. Branch ------ REL_16_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/3235a11c128b5979bce84d56b8044c7fb2e6b61d Modified Files -------------- src/interfaces/libpq/fe-secure-openssl.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) ^ permalink raw reply [nested|flat] 6+ messages in thread
* pgsql: Avoid "unused variable" warning on non-USE_SSL_ENGINE platforms. @ 2024-04-01 23:01 Tom Lane <tgl@sss.pgh.pa.us> 0 siblings, 0 replies; 6+ messages in thread From: Tom Lane @ 2024-04-01 23:01 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Avoid "unused variable" warning on non-USE_SSL_ENGINE platforms. If we are building with openssl but USE_SSL_ENGINE didn't get set, initialize_SSL's variable "pkey" is declared but used nowhere. Apparently this combination hasn't been exercised in the buildfarm before now, because I've not seen this warning before, even though the code has been like this a long time. Move the declaration to silence the warning (and remove its useless initialization). Per buildfarm member sawshark. Back-patch to all supported branches. Branch ------ REL_15_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/98e427af9f59f2515ed67b97c64c9fec16fa7211 Modified Files -------------- src/interfaces/libpq/fe-secure-openssl.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) ^ permalink raw reply [nested|flat] 6+ messages in thread
end of thread, other threads:[~2024-04-01 23:01 UTC | newest] Thread overview: 6+ messages (download: mbox mbox.gz follow: Atom feed) -- links below jump to the message on this page -- 2024-04-01 23:01 pgsql: Avoid "unused variable" warning on non-USE_SSL_ENGINE platforms. Tom Lane <tgl@sss.pgh.pa.us> 2024-04-01 23:01 pgsql: Avoid "unused variable" warning on non-USE_SSL_ENGINE platforms. Tom Lane <tgl@sss.pgh.pa.us> 2024-04-01 23:01 pgsql: Avoid "unused variable" warning on non-USE_SSL_ENGINE platforms. Tom Lane <tgl@sss.pgh.pa.us> 2024-04-01 23:01 pgsql: Avoid "unused variable" warning on non-USE_SSL_ENGINE platforms. Tom Lane <tgl@sss.pgh.pa.us> 2024-04-01 23:01 pgsql: Avoid "unused variable" warning on non-USE_SSL_ENGINE platforms. Tom Lane <tgl@sss.pgh.pa.us> 2024-04-01 23:01 pgsql: Avoid "unused variable" warning on non-USE_SSL_ENGINE platforms. Tom Lane <tgl@sss.pgh.pa.us>
This inbox is served by DDX for PostgreSQL; see mirroring instructions for how to clone and mirror all data and code used for this inbox