pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Tom Lane <tgl@sss.pgh.pa.us>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: Avoid "unused variable" warning on non-USE_SSL_ENGINE platforms.
Date: Mon, 01 Apr 2024 23:01:45 +0000
Message-ID: <E1rrQeu-0002pD-V3@gemulon.postgresql.org> (raw)

Avoid "unused variable" warning on non-USE_SSL_ENGINE platforms.

If we are building with openssl but USE_SSL_ENGINE didn't get set,
initialize_SSL's variable "pkey" is declared but used nowhere.
Apparently this combination hasn't been exercised in the buildfarm
before now, because I've not seen this warning before, even though
the code has been like this a long time.  Move the declaration
to silence the warning (and remove its useless initialization).

Per buildfarm member sawshark.  Back-patch to all supported branches.

Branch
------
REL_14_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/0de5274f59c9d84d803d7f3dc75577d8aa6e56b8

Modified Files
--------------
src/interfaces/libpq/fe-secure-openssl.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)



view thread (6+ messages)  latest in thread

Message-ID: <E1rrQeu-0002pD-V3@gemulon.postgresql.org>
Permalink:  ../E1rrQeu-0002pD-V3@gemulon.postgresql.org/
Also on:    postgresql.org/message-id/E1rrQeu-0002pD-V3@gemulon.postgresql.org

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-committers@postgresql.org
  Cc: tgl@sss.pgh.pa.us, pgsql-committers@lists.postgresql.org
  Subject: Re: pgsql: Avoid "unused variable" warning on non-USE_SSL_ENGINE platforms.
  In-Reply-To: <E1rrQeu-0002pD-V3@gemulon.postgresql.org>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox