From: Etsuro Fujita <efujita@postgresql.org>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: Fix bogus coding in ExecAppendAsyncEventWait().
Date: Thu, 04 Apr 2024 08:37:31 +0000
Message-ID: <E1rsIbD-000Q7g-Ea@gemulon.postgresql.org> (raw)
Fix bogus coding in ExecAppendAsyncEventWait().
No configured-by-FDW events would result in "return" directly out of a
PG_TRY block, making the exception stack dangling. Repair.
Oversight in commit 501cfd07d; back-patch to v14, like that commit, but
as we do not have this issue in HEAD (cf. commit 50c67c201), no need to
apply this patch to it.
In passing, improve a comment about the handling of in-process requests
in a postgres_fdw.c function called from this function.
Alexander Pyhalov, with comment adjustment/improvement by me.
Discussion: https://postgr.es/m/425fa29a429b21b0332737c42a4fdc70%40postgrespro.ru
Branch
------
REL_16_STABLE
Details
-------
https://git.postgresql.org/pg/commitdiff/f6f61a4bd9cc8d771c3b33feeee5cfc039c5e05d
Modified Files
--------------
contrib/postgres_fdw/postgres_fdw.c | 18 ++++++++++--------
src/backend/executor/nodeAppend.c | 31 +++++++++++++++----------------
2 files changed, 25 insertions(+), 24 deletions(-)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-committers@postgresql.org
Cc: efujita@postgresql.org, pgsql-committers@lists.postgresql.org
Subject: Re: pgsql: Fix bogus coding in ExecAppendAsyncEventWait().
In-Reply-To: <E1rsIbD-000Q7g-Ea@gemulon.postgresql.org>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox