pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: John Naylor <john.naylor@postgresql.org>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: Add macro to disable address safety instrumentation
Date: Sat, 06 Apr 2024 05:21:21 +0000
Message-ID: <E1rsyUT-000l5c-0c@gemulon.postgresql.org> (raw)

Add macro to disable address safety instrumentation

fasthash_accum_cstring_aligned() uses a technique, found in various
strlen() implementations, to detect a string's NUL terminator by
reading a word at at time. That triggers failures when testing with
"-fsanitize=address", at least with frontend code. To enable using
this function anywhere, add a function attribute macro to disable
such testing.

Reviewed by Jeff Davis

Discussion: https://postgr.es/m/CANWCAZbwvp7oUEkbw-xP4L0_S_WNKq-J-ucP4RCNDPJnrakUPw%40mail.gmail.com

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/db17594ad73a871a176a9bf96e0589c2cf57052c

Modified Files
--------------
src/include/c.h                      | 13 +++++++++++++
src/include/common/hashfn_unstable.h |  5 ++++-
2 files changed, 17 insertions(+), 1 deletion(-)



Message-ID: <E1rsyUT-000l5c-0c@gemulon.postgresql.org>
Permalink:  ../E1rsyUT-000l5c-0c@gemulon.postgresql.org/
Also on:    postgresql.org/message-id/E1rsyUT-000l5c-0c@gemulon.postgresql.org

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-committers@postgresql.org
  Cc: john.naylor@postgresql.org, pgsql-committers@lists.postgresql.org
  Subject: Re: pgsql: Add macro to disable address safety instrumentation
  In-Reply-To: <E1rsyUT-000l5c-0c@gemulon.postgresql.org>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox