pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Alexander Korotkov <akorotkov@postgresql.org>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: Implement ALTER TABLE ... SPLIT PARTITION ... command
Date: Sat, 06 Apr 2024 22:19:06 +0000
Message-ID: <E1rtENN-000rrV-Tq@gemulon.postgresql.org> (raw)

Implement ALTER TABLE ... SPLIT PARTITION ... command

This new DDL command splits a single partition into several parititions.
Just like ALTER TABLE ... MERGE PARTITIONS ... command, new patitions are
created using createPartitionTable() function with parent partition as the
template.

This commit comprises quite naive implementation which works in single process
and holds the ACCESS EXCLUSIVE LOCK on the parent table during all the
operations including the tuple routing.  This is why this new DDL command
can't be recommended for large partitioned tables under a high load.  However,
this implementation come in handy in certain cases even as is.
Also, it could be used as a foundation for future implementations with lesser
locking and possibly parallel.

Discussion: https://postgr.es/m/c73a1746-0cd0-6bdd-6b23-3ae0b7c0c582%40postgrespro.ru
Author: Dmitry Koval
Reviewed-by: Matthias van de Meent, Laurenz Albe, Zhihong Yu, Justin Pryzby
Reviewed-by: Alvaro Herrera, Robert Haas, Stephane Tachoires

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/87c21bb9412c8ba2727dec5ebcd74d44c2232d11

Modified Files
--------------
doc/src/sgml/ddl.sgml                              |   19 +
doc/src/sgml/ref/alter_table.sgml                  |   65 +-
src/backend/commands/tablecmds.c                   |  411 ++++++
src/backend/parser/gram.y                          |   38 +-
src/backend/parser/parse_utilcmd.c                 |   62 +-
src/backend/partitioning/partbounds.c              |  657 +++++++++
src/backend/utils/adt/ruleutils.c                  |   18 +
src/include/nodes/parsenodes.h                     |    1 +
src/include/parser/kwlist.h                        |    1 +
src/include/partitioning/partbounds.h              |    5 +
src/include/utils/ruleutils.h                      |    2 +
src/test/isolation/expected/partition-split.out    |  190 +++
src/test/isolation/isolation_schedule              |    1 +
src/test/isolation/specs/partition-split.spec      |   54 +
.../modules/test_ddl_deparse/test_ddl_deparse.c    |    3 +
src/test/regress/expected/partition_split.out      | 1417 ++++++++++++++++++++
src/test/regress/parallel_schedule                 |    2 +-
src/test/regress/sql/partition_split.sql           |  833 ++++++++++++
src/tools/pgindent/typedefs.list                   |    1 +
19 files changed, 3766 insertions(+), 14 deletions(-)



view thread (2+ messages)  latest in thread

Message-ID: <E1rtENN-000rrV-Tq@gemulon.postgresql.org>
Permalink:  ../E1rtENN-000rrV-Tq@gemulon.postgresql.org/
Also on:    postgresql.org/message-id/E1rtENN-000rrV-Tq@gemulon.postgresql.org

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-committers@postgresql.org
  Cc: akorotkov@postgresql.org, pgsql-committers@lists.postgresql.org
  Subject: Re: pgsql: Implement ALTER TABLE ... SPLIT PARTITION ... command
  In-Reply-To: <E1rtENN-000rrV-Tq@gemulon.postgresql.org>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox