pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: David Rowley <drowley@postgresql.org>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: Fix incorrect KeeperBlock macro in bump.c
Date: Sun, 07 Apr 2024 23:07:00 +0000
Message-ID: <E1rtbbI-0012Ff-4q@gemulon.postgresql.org> (raw)

Fix incorrect KeeperBlock macro in bump.c

The macro was missing a MAXALIGN around the sizeof(BumpContext) which
would cause problems detecting the keeper block on 32-bit systems that
have a MAXALIGN value of 8.

Thank you to Andres Freund, Tomas Vondra and Tom Lane for investigating
and testing.

Reported-by: Melanie Plageman, Tomas Vondra
Discussion: https://postgr.es/m/CAAKRu_Y6dZjiJEZghgNZp0Gjar1JVq-CH7XGDqExDVHnPgDjuw@mail.gmail.com
Discussion: https://postgr.es/m/a4a10b89-6ba8-4abd-b449-019aafff04fc@enterprisedb.com

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/705ec0565371033082e7b1c278afcb42aa5a7421

Modified Files
--------------
src/backend/utils/mmgr/bump.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)



Message-ID: <E1rtbbI-0012Ff-4q@gemulon.postgresql.org>
Permalink:  ../E1rtbbI-0012Ff-4q@gemulon.postgresql.org/
Also on:    postgresql.org/message-id/E1rtbbI-0012Ff-4q@gemulon.postgresql.org

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-committers@postgresql.org
  Cc: drowley@postgresql.org, pgsql-committers@lists.postgresql.org
  Subject: Re: pgsql: Fix incorrect KeeperBlock macro in bump.c
  In-Reply-To: <E1rtbbI-0012Ff-4q@gemulon.postgresql.org>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox