pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Michael Paquier <michael@paquier.xyz>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: Make GIN test using injection points repeatable
Date: Sun, 07 Apr 2024 23:46:05 +0000
Message-ID: <E1rtcD7-0012Qn-CG@gemulon.postgresql.org> (raw)

Make GIN test using injection points repeatable

As written, the test would fail when run repeatedly because one of the
injection points attached was not detached.  This would not matter if
the test is rewritten to be concurrently safe, but let's be clean and
it is a good practice.

Oversight in 6a1ea02c491d.

Discussion: https://postgr.es/m/ZfP7IDs9TvrKe49x@paquier.xyz

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/997db123c054c597164be77b7bf7da6479471621

Modified Files
--------------
src/test/modules/gin/expected/gin_incomplete_splits.out | 6 ++++++
src/test/modules/gin/sql/gin_incomplete_splits.sql      | 2 ++
2 files changed, 8 insertions(+)



Message-ID: <E1rtcD7-0012Qn-CG@gemulon.postgresql.org>
Permalink:  ../E1rtcD7-0012Qn-CG@gemulon.postgresql.org/
Also on:    postgresql.org/message-id/E1rtcD7-0012Qn-CG@gemulon.postgresql.org

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-committers@postgresql.org
  Cc: michael@paquier.xyz, pgsql-committers@lists.postgresql.org
  Subject: Re: pgsql: Make GIN test using injection points repeatable
  In-Reply-To: <E1rtcD7-0012Qn-CG@gemulon.postgresql.org>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox