From: Alexander Korotkov <akorotkov@postgresql.org>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: Provide a way block-level table AMs could re-use acquire_sample_
Date: Mon, 08 Apr 2024 11:40:03 +0000
Message-ID: <E1rtnM2-0017YV-NU@gemulon.postgresql.org> (raw)
Provide a way block-level table AMs could re-use acquire_sample_rows()
While keeping API the same, this commit provides a way for block-level table
AMs to re-use existing acquire_sample_rows() by providing custom callbacks
for getting the next block and the next tuple.
Reported-by: Andres Freund
Discussion: https://postgr.es/m/20240407214001.jgpg5q3yv33ve6y3%40awork3.anarazel.de
Reviewed-by: Pavel Borisov
Branch
------
master
Details
-------
https://git.postgresql.org/pg/commitdiff/dd1f6b0c172a643a73d6b71259fa2d10378b39eb
Modified Files
--------------
src/backend/access/heap/heapam_handler.c | 12 +++++++
src/backend/commands/analyze.c | 42 +++++++++++++++---------
src/include/access/tableam.h | 13 ++++++++
src/include/commands/vacuum.h | 56 ++++++++++++++++++++++++++++++--
src/tools/pgindent/typedefs.list | 2 ++
5 files changed, 106 insertions(+), 19 deletions(-)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-committers@postgresql.org
Cc: akorotkov@postgresql.org, pgsql-committers@lists.postgresql.org
Subject: Re: pgsql: Provide a way block-level table AMs could re-use acquire_sample_
In-Reply-To: <E1rtnM2-0017YV-NU@gemulon.postgresql.org>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox