pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: John Naylor <john.naylor@postgresql.org>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: Get rid of anonymous struct
Date: Tue, 09 Apr 2024 09:18:43 +0000
Message-ID: <E1ru7co-001GbH-Ey@gemulon.postgresql.org> (raw)

Get rid of anonymous struct

This is a C11 feature, and we require C99. While at it, go the further
step and get rid of the surrounding union (with uintptr_t) entirely,
as there is currently no use case for this file to access the header of
BlocktableEntry as a uintptr_t, and there are no additional alignment
requirements. The least invasive way seems to be to transfer the old
union name to this struct.

Reported by Pavel Borisov and Andres Freund, per buildfarm member mylodon
Reviewed by Pavel Borisov

Discussion: https://postgr.es/m/CALT9ZEH11NYV8AOzKb1bWhCf6J0H=H31f0MgT9xX+HdqvcA1rw@mail.gmail.com

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/bf183f168c447355ba82151f1c7305368a95c834

Modified Files
--------------
src/backend/access/common/tidstore.c | 43 ++++++++++++++++++------------------
1 file changed, 21 insertions(+), 22 deletions(-)



Message-ID: <E1ru7co-001GbH-Ey@gemulon.postgresql.org>
Permalink:  ../E1ru7co-001GbH-Ey@gemulon.postgresql.org/
Also on:    postgresql.org/message-id/E1ru7co-001GbH-Ey@gemulon.postgresql.org

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-committers@postgresql.org
  Cc: john.naylor@postgresql.org, pgsql-committers@lists.postgresql.org
  Subject: Re: pgsql: Get rid of anonymous struct
  In-Reply-To: <E1ru7co-001GbH-Ey@gemulon.postgresql.org>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox