From: David Rowley <drowley@postgresql.org>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: Fixup various StringInfo function usages
Date: Tue, 09 Apr 2024 23:54:17 +0000
Message-ID: <E1ruLI9-001MGu-Br@gemulon.postgresql.org> (raw)
Fixup various StringInfo function usages
This adjusts various appendStringInfo* function calls to use a more
appropriate and efficient function with the same behavior. For example,
use appendStringInfoChar() when appending a single character rather than
appendStringInfo() and appendStringInfoString() when no formatting is
required rather than using appendStringInfo().
All adjustments made here are in code that's new to v17, so it makes
sense to fix these now rather than wait a few years and make
backpatching harder.
Discussion: https://postgr.es/m/CAApHDvojY2UvMiO+9_55ArTj10P1LBNJyyoGB+C65BLDNT0GsQ@mail.gmail.com
Reviewed-by: Nathan Bossart, Tom Lane
Branch
------
master
Details
-------
https://git.postgresql.org/pg/commitdiff/8461424fd717877ead0706984ef9b6440b2a97ad
Modified Files
--------------
contrib/postgres_fdw/deparse.c | 4 ++--
src/backend/replication/logical/slotsync.c | 2 +-
src/backend/replication/logical/tablesync.c | 2 +-
src/backend/utils/adt/ri_triggers.c | 8 ++++----
src/backend/utils/adt/ruleutils.c | 20 ++++++++++----------
5 files changed, 18 insertions(+), 18 deletions(-)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-committers@postgresql.org
Cc: drowley@postgresql.org, pgsql-committers@lists.postgresql.org
Subject: Re: pgsql: Fixup various StringInfo function usages
In-Reply-To: <E1ruLI9-001MGu-Br@gemulon.postgresql.org>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox