pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  

help / color / mirror / Atom feed
From: Masahiko Sawada <msawada@postgresql.org>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: Revert indexed and enlargable binary heap implementation.
Date: Thu, 11 Apr 2024 08:18:36 +0000
Message-ID: <E1rupdk-001ZIw-1s@gemulon.postgresql.org> (raw)

Revert indexed and enlargable binary heap implementation.

This reverts commit b840508644 and bcb14f4abc. These commits were made
for commit 5bec1d6bc5 (Improve eviction algorithm in ReorderBuffer
using max-heap for many subtransactions). However, per discussion,
commit efb8acc0d0 replaced binary heap + index with pairing heap, and
made these commits unnecessary.

Reported-by: Jeff Davis
Discussion: https://postgr.es/m/12747c15811d94efcc5cda72d6b35c80d7bf3443.camel%40j-davis.com

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/810f64a01567610af7b92b0de930f16f3e20064e

Modified Files
--------------
src/backend/executor/nodeGatherMerge.c          |   1 -
src/backend/executor/nodeMergeAppend.c          |   2 +-
src/backend/postmaster/pgarch.c                 |   3 +-
src/backend/replication/logical/reorderbuffer.c |   1 -
src/backend/storage/buffer/bufmgr.c             |   1 -
src/bin/pg_dump/pg_backup_archiver.c            |   1 -
src/bin/pg_dump/pg_dump_sort.c                  |   2 +-
src/common/binaryheap.c                         | 245 ++++--------------------
src/include/lib/binaryheap.h                    |  40 +---
src/tools/pgindent/typedefs.list                |   1 -
10 files changed, 38 insertions(+), 259 deletions(-)



Message-ID: <E1rupdk-001ZIw-1s@gemulon.postgresql.org>
Permalink:  ../E1rupdk-001ZIw-1s@gemulon.postgresql.org/
Also on:    postgresql.org/message-id/E1rupdk-001ZIw-1s@gemulon.postgresql.org

 · 

reply
Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-committers@postgresql.org
  Cc: msawada@postgresql.org, pgsql-committers@lists.postgresql.org
  Subject: Re: pgsql: Revert indexed and enlargable binary heap implementation.
  In-Reply-To: <E1rupdk-001ZIw-1s@gemulon.postgresql.org>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox