From: Andrew Dunstan <andrew@dunslane.net>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: Don't allocate large buffer on the stack in pg_verifybackup
Date: Fri, 12 Apr 2024 14:59:20 +0000
Message-ID: <E1rvIN6-001knx-4a@gemulon.postgresql.org> (raw)
Don't allocate large buffer on the stack in pg_verifybackup
Per complaint from Andres Freund. Follow his suggestion to allocate the
buffer once in the calling routine instead.
Also make a tiny indentation improvement.
Discussion: https://postgr.es/m/20240411190147.a3yries632olfcgg@awork3.anarazel.de
Branch
------
master
Details
-------
https://git.postgresql.org/pg/commitdiff/929c05774b512bdf7ea4a5912fa2f4d63fc90712
Modified Files
--------------
src/bin/pg_verifybackup/pg_verifybackup.c | 17 +++++++++++------
1 file changed, 11 insertions(+), 6 deletions(-)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-committers@postgresql.org
Cc: andrew@dunslane.net, pgsql-committers@lists.postgresql.org
Subject: Re: pgsql: Don't allocate large buffer on the stack in pg_verifybackup
In-Reply-To: <E1rvIN6-001knx-4a@gemulon.postgresql.org>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox