pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Tomas Vondra <tomas.vondra@postgresql.org>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: Stabilize test of BRIN parallel create
Date: Wed, 17 Apr 2024 14:20:31 +0000
Message-ID: <E1rx69G-002WHP-Kz@gemulon.postgresql.org> (raw)

Stabilize test of BRIN parallel create

As explained in 4d916dd876, the test instability is caused by delayed
cleanup of deleted rows. This commit removes the DELETE, stabilizing the
test without accidentally disabling parallel builds.

The intent of the delete however was to produce empty ranges, and test
that the parallel index build populates those correctly. But there's
another way to create empty ranges - partial indexes, which does not
rely on cleanup of deleted rows.

Idea to use partial indexes by Matthias van de Meent, patch by me.

Discussion: https://postgr.es/m/95d9cd43-5a92-407c-b7e4-54cd303630fe%40enterprisedb.com

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/0bd4b0689ba1f12fbbd9919ca76a71df3e7702a2

Modified Files
--------------
contrib/pageinspect/expected/brin.out | 13 ++++++-------
contrib/pageinspect/sql/brin.sql      | 15 ++++++---------
2 files changed, 12 insertions(+), 16 deletions(-)



view thread (3+ messages)

Message-ID: <E1rx69G-002WHP-Kz@gemulon.postgresql.org>
Permalink:  ../E1rx69G-002WHP-Kz@gemulon.postgresql.org/
Also on:    postgresql.org/message-id/E1rx69G-002WHP-Kz@gemulon.postgresql.org

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-committers@postgresql.org
  Cc: tomas.vondra@postgresql.org, pgsql-committers@lists.postgresql.org
  Subject: Re: pgsql: Stabilize test of BRIN parallel create
  In-Reply-To: <E1rx69G-002WHP-Kz@gemulon.postgresql.org>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox