pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Alexander Korotkov <akorotkov@postgresql.org>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: Refactoring for CommitTransactionCommand()/AbortCurrentTransacti
Date: Wed, 17 Apr 2024 21:46:44 +0000
Message-ID: <E1rxD76-002Ytj-57@gemulon.postgresql.org> (raw)

Refactoring for CommitTransactionCommand()/AbortCurrentTransaction()

fefd9a3fed turned tail recursion of CommitTransactionCommand() and
AbortCurrentTransaction() into iteration.  However, it splits the handling of
cases between different functions.

This commit puts the handling of all the cases into
AbortCurrentTransactionInternal() and CommitTransactionCommandInternal().
Now CommitTransactionCommand() and AbortCurrentTransaction() are just doing
the repeated calls of internal functions.

Reported-by: Andres Freund
Discussion: https://postgr.es/m/20240415224834.w6piwtefskoh32mv%40awork3.anarazel.de
Author: Andres Freund

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/40126ac68f2ff96351cd6071350eb2d5cbd50145

Modified Files
--------------
src/backend/access/transam/xact.c | 155 +++++++++++++++++---------------------
1 file changed, 71 insertions(+), 84 deletions(-)



view thread (4+ messages)

Message-ID: <E1rxD76-002Ytj-57@gemulon.postgresql.org>
Permalink:  ../E1rxD76-002Ytj-57@gemulon.postgresql.org/
Also on:    postgresql.org/message-id/E1rxD76-002Ytj-57@gemulon.postgresql.org

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-committers@postgresql.org
  Cc: akorotkov@postgresql.org, pgsql-committers@lists.postgresql.org
  Subject: Re: pgsql: Refactoring for CommitTransactionCommand()/AbortCurrentTransacti
  In-Reply-To: <E1rxD76-002Ytj-57@gemulon.postgresql.org>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox