From: Amit Langote <amitlan@postgresql.org>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: SQL/JSON: Improve some error messages
Date: Thu, 18 Apr 2024 06:51:26 +0000
Message-ID: <E1rxLcE-002e2D-4R@gemulon.postgresql.org> (raw)
SQL/JSON: Improve some error messages
This improves some error messages emitted by SQL/JSON query functions
by mentioning column name when available, such as when they are
invoked as part of evaluating JSON_TABLE() columns. To do so, a new
field column_name is added to both JsonFuncExpr and JsonExpr that is
only populated when creating those nodes for transformed JSON_TABLE()
columns.
While at it, relevant error messages are reworded for clarity.
Reported-by: Jian He <jian.universality@gmail.com>
Suggested-by: Jian He <jian.universality@gmail.com>
Discussion: https://postgr.es/m/CACJufxG_e0QLCgaELrr2ZNz7AxPeGCNKAORe3fHtFCQLsH4J4Q@mail.gmail.com
Branch
------
master
Details
-------
https://git.postgresql.org/pg/commitdiff/b4fad46b6bc8a9bf46ff689bcb1bd4edf8f267af
Modified Files
--------------
src/backend/executor/execExprInterp.c | 43 ++++++++++++----------
src/backend/parser/parse_expr.c | 1 +
src/backend/parser/parse_jsontable.c | 10 +++---
src/backend/utils/adt/jsonpath_exec.c | 45 +++++++++++++++++-------
src/include/nodes/parsenodes.h | 2 ++
src/include/nodes/primnodes.h | 3 ++
src/include/utils/jsonpath.h | 6 ++--
src/test/regress/expected/sqljson_jsontable.out | 10 ++++--
src/test/regress/expected/sqljson_queryfuncs.out | 30 ++++++++--------
src/test/regress/sql/sqljson_jsontable.sql | 3 ++
10 files changed, 96 insertions(+), 57 deletions(-)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-committers@postgresql.org
Cc: amitlan@postgresql.org, pgsql-committers@lists.postgresql.org
Subject: Re: pgsql: SQL/JSON: Improve some error messages
In-Reply-To: <E1rxLcE-002e2D-4R@gemulon.postgresql.org>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox