pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Amit Langote <amitlan@postgresql.org>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: SQL/JSON: Miscellaneous fixes and improvements
Date: Thu, 18 Apr 2024 06:51:26 +0000
Message-ID: <E1rxLcE-002e2H-61@gemulon.postgresql.org> (raw)

SQL/JSON: Miscellaneous fixes and improvements

This addresses some post-commit review comments for commits 6185c973,
de3600452, and 9425c596a0, with the following changes:

* Fix JSON_TABLE() syntax documentation to use the term
  "path_expression" for JSON path expressions instead of
  "json_path_specification" to be consistent with the other SQL/JSON
  functions.

* Fix a typo in the example code in JSON_TABLE() documentation.

* Rewrite some newly added comments in jsonpath.h.

* In JsonPathQuery(), add missing cast to int before printing an enum
  value.

Reported-by: Jian He <jian.universality@gmail.com>
Discussion: https://postgr.es/m/CACJufxG_e0QLCgaELrr2ZNz7AxPeGCNKAORe3fHtFCQLsH4J4Q@mail.gmail.com

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/ef744ebb7340d42361ebd88d068b27b17e69de18

Modified Files
--------------
doc/src/sgml/func.sgml                | 9 +++++----
src/backend/utils/adt/jsonpath_exec.c | 2 +-
src/include/utils/jsonpath.h          | 8 +++-----
3 files changed, 9 insertions(+), 10 deletions(-)



view thread (2+ messages)

Message-ID: <E1rxLcE-002e2H-61@gemulon.postgresql.org>
Permalink:  ../E1rxLcE-002e2H-61@gemulon.postgresql.org/
Also on:    postgresql.org/message-id/E1rxLcE-002e2H-61@gemulon.postgresql.org

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-committers@postgresql.org
  Cc: amitlan@postgresql.org, pgsql-committers@lists.postgresql.org
  Subject: Re: pgsql: SQL/JSON: Miscellaneous fixes and improvements
  In-Reply-To: <E1rxLcE-002e2H-61@gemulon.postgresql.org>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox