pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Robert Haas <rhaas@postgresql.org>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: Use tempdir_short instead of tempdir.
Date: Fri, 19 Apr 2024 19:59:38 +0000
Message-ID: <E1rxuOX-002tRe-Vk@gemulon.postgresql.org> (raw)

Use tempdir_short instead of tempdir.

After cd64dc42d1e1b03e57e6ba3d316e4f9dec52a78d, a significant
percentage of the buildfarm got unhappy, because pg_basebackup chokes
if it tries to create a tarfile with symlink more than 99 characters
in length. To try to fix that problem, use tempdir_short instead of
tempdir, as we do in pg_verifybackup's 003_corruption.pl.

There's a more complicated workaround for the same issue in
pg_basebackup's 010_pg_basebackup.pl, but I'm not clear whether
there's any reason to do it that way here. For now, let's try this,
to at least get the buildfarm green again.

A better long-term fix would be to figure out how to generate tar
files containing long symlinks, but that will have to wait for
another time.

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/fa7036dd6644d13233b475874a94754a5903e35a

Modified Files
--------------
src/bin/pg_combinebackup/t/002_compare_backups.pl | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)



view thread (2+ messages)

Message-ID: <E1rxuOX-002tRe-Vk@gemulon.postgresql.org>
Permalink:  ../E1rxuOX-002tRe-Vk@gemulon.postgresql.org/
Also on:    postgresql.org/message-id/E1rxuOX-002tRe-Vk@gemulon.postgresql.org

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-committers@postgresql.org
  Cc: rhaas@postgresql.org, pgsql-committers@lists.postgresql.org
  Subject: Re: pgsql: Use tempdir_short instead of tempdir.
  In-Reply-To: <E1rxuOX-002tRe-Vk@gemulon.postgresql.org>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox