From: Robert Haas <rhaas@postgresql.org>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: Revert recent ill-advised test case changes.
Date: Fri, 19 Apr 2024 21:24:10 +0000
Message-ID: <E1rxviL-002u3I-KD@gemulon.postgresql.org> (raw)
Revert recent ill-advised test case changes.
Commit 6bf5c42b5546984df29289918f952e6211069c54 cannot work on Windows,
because it lacks symlink support. While the bug fix in commit
cd64dc42d1e1b03e57e6ba3d316e4f9dec52a78d is correct as far as I know,
the test case changes depend on the previous commit, so this will
have to live without test coverage until we can come up with a better
solution. Commit fa7036dd6644d13233b475874a94754a5903e35a was a test
case bug fix on top of those two, to prevent failures on Linux, so that
has to come out as well.
Per the buildfarm, CI, and Thomas Munro.
Branch
------
master
Details
-------
https://git.postgresql.org/pg/commitdiff/82023d47de9e262730b1f9b4ea77fae201a89d0a
Modified Files
--------------
src/bin/pg_basebackup/t/010_pg_basebackup.pl | 21 ++++-
src/bin/pg_combinebackup/t/002_compare_backups.pl | 32 +-------
src/test/perl/PostgreSQL/Test/Cluster.pm | 93 ++---------------------
3 files changed, 28 insertions(+), 118 deletions(-)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-committers@postgresql.org
Cc: rhaas@postgresql.org, pgsql-committers@lists.postgresql.org
Subject: Re: pgsql: Revert recent ill-advised test case changes.
In-Reply-To: <E1rxviL-002u3I-KD@gemulon.postgresql.org>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox