From: Amit Kapila <akapila@postgresql.org>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: Fix the handling of the failover option in subscription commands
Date: Tue, 23 Apr 2024 07:09:35 +0000
Message-ID: <E1rzAHW-003Svu-Q4@gemulon.postgresql.org> (raw)
Fix the handling of the failover option in subscription commands.
Do not allow ALTER SUBSCRIPTION ... SET (failover = on|off) in a
transaction block as the changed failover option of the slot can't be
rolled back. For the same reason, we refrain from altering the replication
slot's failover property if the subscription is created with a valid
slot_name and create_slot=false.
Reprted-by: Kuroda Hayato
Author: Hou Zhijie
Reviewed-by: Shveta Malik, Bertrand Drouvot, Kuroda Hayato
Discussion: https://postgr.es/m/OS0PR01MB57165542B09DFA4943830BF294082@OS0PR01MB5716.jpnprd01.prod.outlook.com
Branch
------
master
Details
-------
https://git.postgresql.org/pg/commitdiff/b29cbd3da4e37db17026b9fe58fb46fe83f467bf
Modified Files
--------------
doc/src/sgml/ref/alter_subscription.sgml | 7 +++---
doc/src/sgml/ref/create_subscription.sgml | 18 ++++++++++++--
doc/src/sgml/ref/pg_dump.sgml | 6 +----
src/backend/commands/subscriptioncmds.c | 28 +++++-----------------
src/bin/pg_dump/pg_dump.c | 27 ++++++++++-----------
.../recovery/t/040_standby_failover_slots_sync.pl | 20 +++-------------
src/test/regress/expected/subscription.out | 7 ++++--
src/test/regress/sql/subscription.sql | 6 ++++-
8 files changed, 52 insertions(+), 67 deletions(-)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-committers@postgresql.org
Cc: akapila@postgresql.org, pgsql-committers@lists.postgresql.org
Subject: Re: pgsql: Fix the handling of the failover option in subscription commands
In-Reply-To: <E1rzAHW-003Svu-Q4@gemulon.postgresql.org>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox