pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Tom Lane <tgl@sss.pgh.pa.us>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: Remove some unnecessary fields from executor nodes.
Date: Tue, 23 Apr 2024 16:55:33 +0000
Message-ID: <E1rzJQb-003Wvc-Cu@gemulon.postgresql.org> (raw)

Remove some unnecessary fields from executor nodes.

JsonExprState.input_finfo is only assigned to, never read, and
it's really fairly useless since the value can be gotten out of
the adjacent input_fcinfo field.  Let's remove it before someone
starts to depend on it.

While here, also remove TidScanState.tss_htup and AggState.combinedproj,
which are referenced nowhere.  Those should have been removed by the
commits that caused them to become disused, but were not.

I don't think a catversion bump is necessary here, since plan trees
are never stored on disk.

Matthias van de Meent

Discussion: https://postgr.es/m/CAEze2WjsY4d0TBymLNGK4zpttUcg_YZaTjyWz2VfDUV6YH8wXQ@mail.gmail.com

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/b7d35d393edbe2d4333dde81496e8a362abc85bd

Modified Files
--------------
src/backend/executor/execExpr.c | 1 -
src/include/nodes/execnodes.h   | 4 ----
2 files changed, 5 deletions(-)



view thread (2+ messages)

Message-ID: <E1rzJQb-003Wvc-Cu@gemulon.postgresql.org>
Permalink:  ../E1rzJQb-003Wvc-Cu@gemulon.postgresql.org/
Also on:    postgresql.org/message-id/E1rzJQb-003Wvc-Cu@gemulon.postgresql.org

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-committers@postgresql.org
  Cc: tgl@sss.pgh.pa.us, pgsql-committers@lists.postgresql.org
  Subject: Re: pgsql: Remove some unnecessary fields from executor nodes.
  In-Reply-To: <E1rzJQb-003Wvc-Cu@gemulon.postgresql.org>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox