pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  

help / color / mirror / Atom feed
From: Andrew Dunstan <andrew@dunslane.net>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: Post review fixes for test_json_parser test module
Date: Tue, 23 Apr 2024 19:33:34 +0000
Message-ID: <E1rzLtV-003YHP-Uc@gemulon.postgresql.org> (raw)

Post review fixes for test_json_parser test module

. Add missing copytight notices
. improve code coverage
. put work files in a temp directory in the standard location
. improve error checking in C code
. indent perl files with perltidy
. add some comments

per comments from Michael Paquier

Discussion: https://postgr.es/m/ZiC3-cdFys4-6xSk@paquier.xyz

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/ba3e6e2bca97df14920375b0a1ebf4eab95b78b5

Modified Files
--------------
.../t/001_test_json_parser_incremental.pl          | 15 +++-
src/test/modules/test_json_parser/t/002_inline.pl  | 93 ++++++++++++++++------
.../test_json_parser/t/003_test_semantic.pl        | 15 +++-
.../test_json_parser/t/004_test_parser_perf.pl     | 18 +++--
.../test_json_parser_incremental.c                 | 25 ++++--
.../test_json_parser/test_json_parser_perf.c       | 13 ++-
src/test/modules/test_json_parser/tiny.json        |  1 +
src/test/modules/test_json_parser/tiny.out         |  1 +
8 files changed, 133 insertions(+), 48 deletions(-)



view thread (2+ messages)

Message-ID: <E1rzLtV-003YHP-Uc@gemulon.postgresql.org>
Permalink:  ../E1rzLtV-003YHP-Uc@gemulon.postgresql.org/
Also on:    postgresql.org/message-id/E1rzLtV-003YHP-Uc@gemulon.postgresql.org

 · 

reply
Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-committers@postgresql.org
  Cc: andrew@dunslane.net, pgsql-committers@lists.postgresql.org
  Subject: Re: pgsql: Post review fixes for test_json_parser test module
  In-Reply-To: <E1rzLtV-003YHP-Uc@gemulon.postgresql.org>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox