pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  

help / color / mirror / Atom feed
From: Masahiko Sawada <msawada@postgresql.org>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: radixtree: Fix SIGSEGV at update of embeddable value to non-embe
Date: Thu, 25 Apr 2024 12:49:37 +0000
Message-ID: <E1rzyXh-003ozn-CB@gemulon.postgresql.org> (raw)

radixtree: Fix SIGSEGV at update of embeddable value to non-embeddable.

Also, fix a memory leak when updating from non-embeddable to
embeddable. Both were unreachable without adding C code.

Reported-by: Noah Misch
Author: Noah Misch
Reviewed-by: Masahiko Sawada, John Naylor
Discussion: https://postgr.es/m/20240424210319.4c.nmisch%40google.com

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/bb7f195ff78851e5fcee7230108a16d70be13579

Modified Files
--------------
src/include/lib/radixtree.h                        |   6 +-
.../test_tidstore/expected/test_tidstore.out       | 116 ++++++++++++++++++++-
.../modules/test_tidstore/sql/test_tidstore.sql    |  21 +++-
src/test/modules/test_tidstore/test_tidstore.c     |  15 +++
4 files changed, 148 insertions(+), 10 deletions(-)



Message-ID: <E1rzyXh-003ozn-CB@gemulon.postgresql.org>
Permalink:  ../E1rzyXh-003ozn-CB@gemulon.postgresql.org/
Also on:    postgresql.org/message-id/E1rzyXh-003ozn-CB@gemulon.postgresql.org

 · 

reply
Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-committers@postgresql.org
  Cc: msawada@postgresql.org, pgsql-committers@lists.postgresql.org
  Subject: Re: pgsql: radixtree: Fix SIGSEGV at update of embeddable value to non-embe
  In-Reply-To: <E1rzyXh-003ozn-CB@gemulon.postgresql.org>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox