pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Andres Freund <andres@anarazel.de>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: Avoid unnecessary "touch meson.build" in vpath builds
Date: Thu, 25 Apr 2024 14:55:02 +0000
Message-ID: <E1s00V4-003peR-3t@gemulon.postgresql.org> (raw)

Avoid unnecessary "touch meson.build" in vpath builds

In e6927270cd1 I added a 'touch meson.build' to configure.ac, to ensure
conflicts between in-tree configure based builds and meson builds are
automatically detected. Unfortunately I omitted spaces around the condition
restricting this to in-tree builds, leading to touch meson.build to also be
executed in vpath builds. While the only consequence of this buglet is an
unnecessary empty file in build directories, it seems worth backpatching.

Reported-by: Christoph Berg <myon@debian.org>
Discussion: https://postgr.es/m/20240417230002.mb2gv3hyetyn67gk@awork3.anarazel.de
Backpatch: 16-, where the meson based build was added

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/6d4bc96eb77bca6277880f218cd7a2f9e44bddc0

Modified Files
--------------
configure    | 2 +-
configure.ac | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)



view thread (2+ messages)

Message-ID: <E1s00V4-003peR-3t@gemulon.postgresql.org>
Permalink:  ../E1s00V4-003peR-3t@gemulon.postgresql.org/
Also on:    postgresql.org/message-id/E1s00V4-003peR-3t@gemulon.postgresql.org

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-committers@postgresql.org
  Cc: andres@anarazel.de, pgsql-committers@lists.postgresql.org
  Subject: Re: pgsql: Avoid unnecessary "touch meson.build" in vpath builds
  In-Reply-To: <E1s00V4-003peR-3t@gemulon.postgresql.org>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox