pg.ddx.io pgsql-committers@postgresql.org mailing list archivehelp / color / mirror / Atom feed
pgsql: Skip invalid database pg_upgrade test on obsolete servers 2+ messages / 1 participants [nested] [flat]
* pgsql: Skip invalid database pg_upgrade test on obsolete servers @ 2024-05-01 09:51 Alvaro Herrera <alvherre@alvh.no-ip.org> 0 siblings, 0 replies; 2+ messages in thread From: Alvaro Herrera @ 2024-05-01 09:51 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Skip invalid database pg_upgrade test on obsolete servers When testing pg_upgrade against an old server, ignore failures on the check to upgrade invalid databases. This is necessary because old servers don't know to raise the appropriate error of the database being invalid. This change causes no reduction in coverage, because such old versions don't know to mark databases invalid when a drop is interrupted; but testing against such old servers is useful in some circumstances. Backpatch to 16, where it cherry-picks with minimal conflicts. On 16, perltidy 20230309 chooses to change an unrelated line. I let it do that because that's the version we document as preferred for that branch, even though it would make other changes to many other files in the tree. Discussion: https://postgr.es/m/202404181539.lh42llaesnv3@alvherre.pgsql Branch ------ REL_16_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/5a0ac6855a21917ada42d8bb83d3d5ac4c2eeda8 Modified Files -------------- src/bin/pg_upgrade/t/002_pg_upgrade.pl | 41 ++++++++++++++++++++++------------ 1 file changed, 27 insertions(+), 14 deletions(-) ^ permalink raw reply [nested|flat] 2+ messages in thread
* pgsql: Skip invalid database pg_upgrade test on obsolete servers @ 2024-05-01 09:51 Alvaro Herrera <alvherre@alvh.no-ip.org> 0 siblings, 0 replies; 2+ messages in thread From: Alvaro Herrera @ 2024-05-01 09:51 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Skip invalid database pg_upgrade test on obsolete servers When testing pg_upgrade against an old server, ignore failures on the check to upgrade invalid databases. This is necessary because old servers don't know to raise the appropriate error of the database being invalid. This change causes no reduction in coverage, because such old versions don't know to mark databases invalid when a drop is interrupted; but testing against such old servers is useful in some circumstances. Backpatch to 16, where it cherry-picks with minimal conflicts. On 16, perltidy 20230309 chooses to change an unrelated line. I let it do that because that's the version we document as preferred for that branch, even though it would make other changes to many other files in the tree. Discussion: https://postgr.es/m/202404181539.lh42llaesnv3@alvherre.pgsql Branch ------ master Details ------- https://git.postgresql.org/pg/commitdiff/56455ebd354e35ebd9d17455759abda70f9edcea Modified Files -------------- src/bin/pg_upgrade/t/002_pg_upgrade.pl | 38 ++++++++++++++++++++++------------ 1 file changed, 25 insertions(+), 13 deletions(-) ^ permalink raw reply [nested|flat] 2+ messages in thread
end of thread, other threads:[~2024-05-01 09:51 UTC | newest] Thread overview: 2+ messages (download: mbox mbox.gz follow: Atom feed) -- links below jump to the message on this page -- 2024-05-01 09:51 pgsql: Skip invalid database pg_upgrade test on obsolete servers Alvaro Herrera <alvherre@alvh.no-ip.org> 2024-05-01 09:51 pgsql: Skip invalid database pg_upgrade test on obsolete servers Alvaro Herrera <alvherre@alvh.no-ip.org>
This inbox is served by DDX for PostgreSQL; see mirroring instructions for how to clone and mirror all data and code used for this inbox