From: Alvaro Herrera <alvherre@alvh.no-ip.org>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: Skip invalid database pg_upgrade test on obsolete servers
Date: Wed, 01 May 2024 09:51:15 +0000
Message-ID: <E1s26cM-000wvV-LG@gemulon.postgresql.org> (raw)
Skip invalid database pg_upgrade test on obsolete servers
When testing pg_upgrade against an old server, ignore failures on the
check to upgrade invalid databases. This is necessary because old
servers don't know to raise the appropriate error of the database being
invalid.
This change causes no reduction in coverage, because such old versions
don't know to mark databases invalid when a drop is interrupted; but
testing against such old servers is useful in some circumstances.
Backpatch to 16, where it cherry-picks with minimal conflicts.
On 16, perltidy 20230309 chooses to change an unrelated line. I let it
do that because that's the version we document as preferred for that
branch, even though it would make other changes to many other files in
the tree.
Discussion: https://postgr.es/m/202404181539.lh42llaesnv3@alvherre.pgsql
Branch
------
REL_16_STABLE
Details
-------
https://git.postgresql.org/pg/commitdiff/5a0ac6855a21917ada42d8bb83d3d5ac4c2eeda8
Modified Files
--------------
src/bin/pg_upgrade/t/002_pg_upgrade.pl | 41 ++++++++++++++++++++++------------
1 file changed, 27 insertions(+), 14 deletions(-)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-committers@postgresql.org
Cc: alvherre@alvh.no-ip.org, pgsql-committers@lists.postgresql.org
Subject: Re: pgsql: Skip invalid database pg_upgrade test on obsolete servers
In-Reply-To: <E1s26cM-000wvV-LG@gemulon.postgresql.org>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox