pg.ddx.io pgsql-committers@postgresql.org mailing list archivehelp / color / mirror / Atom feed
pgsql: Ensure that "pg_restore -l" reports dependent TOC entries correc 6+ messages / 1 participants [nested] [flat]
* pgsql: Ensure that "pg_restore -l" reports dependent TOC entries correc @ 2024-05-07 22:23 Tom Lane <tgl@sss.pgh.pa.us> 0 siblings, 0 replies; 6+ messages in thread From: Tom Lane @ 2024-05-07 22:23 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Ensure that "pg_restore -l" reports dependent TOC entries correctly. If -l was specified together with selective-restore options such as -n or -N, dependent TOC entries such as comments would be omitted from the listing, even when an actual restore would have selected them. This happened because PrintTOCSummary neglected to update the te->reqs marking of the entry they depended on. Per report from Justin Pryzby. This has been wrong since 0d4e6ed30 taught _tocEntryRequired to sometimes look at the "reqs" marking of other TOC entries, so back-patch to all supported branches. Discussion: https://postgr.es/m/ZjoeirG7yxODdC4P@pryzbyj2023 Branch ------ master Details ------- https://git.postgresql.org/pg/commitdiff/c1aea206e3e333b8c9f8be20422426ae845dd0cf Modified Files -------------- src/bin/pg_dump/pg_backup_archiver.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) ^ permalink raw reply [nested|flat] 6+ messages in thread
* pgsql: Ensure that "pg_restore -l" reports dependent TOC entries correc @ 2024-05-07 22:23 Tom Lane <tgl@sss.pgh.pa.us> 0 siblings, 0 replies; 6+ messages in thread From: Tom Lane @ 2024-05-07 22:23 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Ensure that "pg_restore -l" reports dependent TOC entries correctly. If -l was specified together with selective-restore options such as -n or -N, dependent TOC entries such as comments would be omitted from the listing, even when an actual restore would have selected them. This happened because PrintTOCSummary neglected to update the te->reqs marking of the entry they depended on. Per report from Justin Pryzby. This has been wrong since 0d4e6ed30 taught _tocEntryRequired to sometimes look at the "reqs" marking of other TOC entries, so back-patch to all supported branches. Discussion: https://postgr.es/m/ZjoeirG7yxODdC4P@pryzbyj2023 Branch ------ REL_16_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/5dce8ce0ac48bc8af33d7efcdbfee713781598ed Modified Files -------------- src/bin/pg_dump/pg_backup_archiver.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) ^ permalink raw reply [nested|flat] 6+ messages in thread
* pgsql: Ensure that "pg_restore -l" reports dependent TOC entries correc @ 2024-05-07 22:23 Tom Lane <tgl@sss.pgh.pa.us> 0 siblings, 0 replies; 6+ messages in thread From: Tom Lane @ 2024-05-07 22:23 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Ensure that "pg_restore -l" reports dependent TOC entries correctly. If -l was specified together with selective-restore options such as -n or -N, dependent TOC entries such as comments would be omitted from the listing, even when an actual restore would have selected them. This happened because PrintTOCSummary neglected to update the te->reqs marking of the entry they depended on. Per report from Justin Pryzby. This has been wrong since 0d4e6ed30 taught _tocEntryRequired to sometimes look at the "reqs" marking of other TOC entries, so back-patch to all supported branches. Discussion: https://postgr.es/m/ZjoeirG7yxODdC4P@pryzbyj2023 Branch ------ REL_15_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/6a458d93ba5f8d4b12db6a78d31ba2623e9cb594 Modified Files -------------- src/bin/pg_dump/pg_backup_archiver.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) ^ permalink raw reply [nested|flat] 6+ messages in thread
* pgsql: Ensure that "pg_restore -l" reports dependent TOC entries correc @ 2024-05-07 22:23 Tom Lane <tgl@sss.pgh.pa.us> 0 siblings, 0 replies; 6+ messages in thread From: Tom Lane @ 2024-05-07 22:23 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Ensure that "pg_restore -l" reports dependent TOC entries correctly. If -l was specified together with selective-restore options such as -n or -N, dependent TOC entries such as comments would be omitted from the listing, even when an actual restore would have selected them. This happened because PrintTOCSummary neglected to update the te->reqs marking of the entry they depended on. Per report from Justin Pryzby. This has been wrong since 0d4e6ed30 taught _tocEntryRequired to sometimes look at the "reqs" marking of other TOC entries, so back-patch to all supported branches. Discussion: https://postgr.es/m/ZjoeirG7yxODdC4P@pryzbyj2023 Branch ------ REL_14_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/52b23b4e1c6f703a6617c027a5def99772af4ce4 Modified Files -------------- src/bin/pg_dump/pg_backup_archiver.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) ^ permalink raw reply [nested|flat] 6+ messages in thread
* pgsql: Ensure that "pg_restore -l" reports dependent TOC entries correc @ 2024-05-07 22:23 Tom Lane <tgl@sss.pgh.pa.us> 0 siblings, 0 replies; 6+ messages in thread From: Tom Lane @ 2024-05-07 22:23 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Ensure that "pg_restore -l" reports dependent TOC entries correctly. If -l was specified together with selective-restore options such as -n or -N, dependent TOC entries such as comments would be omitted from the listing, even when an actual restore would have selected them. This happened because PrintTOCSummary neglected to update the te->reqs marking of the entry they depended on. Per report from Justin Pryzby. This has been wrong since 0d4e6ed30 taught _tocEntryRequired to sometimes look at the "reqs" marking of other TOC entries, so back-patch to all supported branches. Discussion: https://postgr.es/m/ZjoeirG7yxODdC4P@pryzbyj2023 Branch ------ REL_13_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/b99dc6694ca64d8e5bd5ee2b0c6bdbbb8cdf4c99 Modified Files -------------- src/bin/pg_dump/pg_backup_archiver.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) ^ permalink raw reply [nested|flat] 6+ messages in thread
* pgsql: Ensure that "pg_restore -l" reports dependent TOC entries correc @ 2024-05-07 22:23 Tom Lane <tgl@sss.pgh.pa.us> 0 siblings, 0 replies; 6+ messages in thread From: Tom Lane @ 2024-05-07 22:23 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Ensure that "pg_restore -l" reports dependent TOC entries correctly. If -l was specified together with selective-restore options such as -n or -N, dependent TOC entries such as comments would be omitted from the listing, even when an actual restore would have selected them. This happened because PrintTOCSummary neglected to update the te->reqs marking of the entry they depended on. Per report from Justin Pryzby. This has been wrong since 0d4e6ed30 taught _tocEntryRequired to sometimes look at the "reqs" marking of other TOC entries, so back-patch to all supported branches. Discussion: https://postgr.es/m/ZjoeirG7yxODdC4P@pryzbyj2023 Branch ------ REL_12_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/a3c00ab1545029ee5d8c87d55da976ae1ccf2ba8 Modified Files -------------- src/bin/pg_dump/pg_backup_archiver.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) ^ permalink raw reply [nested|flat] 6+ messages in thread
end of thread, other threads:[~2024-05-07 22:23 UTC | newest] Thread overview: 6+ messages (download: mbox mbox.gz follow: Atom feed) -- links below jump to the message on this page -- 2024-05-07 22:23 pgsql: Ensure that "pg_restore -l" reports dependent TOC entries correc Tom Lane <tgl@sss.pgh.pa.us> 2024-05-07 22:23 pgsql: Ensure that "pg_restore -l" reports dependent TOC entries correc Tom Lane <tgl@sss.pgh.pa.us> 2024-05-07 22:23 pgsql: Ensure that "pg_restore -l" reports dependent TOC entries correc Tom Lane <tgl@sss.pgh.pa.us> 2024-05-07 22:23 pgsql: Ensure that "pg_restore -l" reports dependent TOC entries correc Tom Lane <tgl@sss.pgh.pa.us> 2024-05-07 22:23 pgsql: Ensure that "pg_restore -l" reports dependent TOC entries correc Tom Lane <tgl@sss.pgh.pa.us> 2024-05-07 22:23 pgsql: Ensure that "pg_restore -l" reports dependent TOC entries correc Tom Lane <tgl@sss.pgh.pa.us>
This inbox is served by DDX for PostgreSQL; see mirroring instructions for how to clone and mirror all data and code used for this inbox