From: Alvaro Herrera <alvherre@alvh.no-ip.org>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: Fix test case to do what it intends to
Date: Mon, 13 May 2024 08:35:11 +0000
Message-ID: <E1s6R9K-000jVs-Kz@gemulon.postgresql.org> (raw)
Fix test case to do what it intends to
This test case intended to fail because setting a column as generated to
the partitioned table while leaving the partition alone is not allowed;
but instead failed because of a discrepancy of not-null constraint. Fix
this by adding the not-null constraint first, then set the column as
generated in a separate ALTER TABLE command, which gets the expected
error. Also, because the next test also wants to set the column as
not-null, add a BEGIN/ROLLBACK block so that the added not-null is
removed.
Oversight in 699586315704.
Branch
------
master
Details
-------
https://git.postgresql.org/pg/commitdiff/e89f4c66182e409b6643b1e8426371011dc25217
Modified Files
--------------
src/test/regress/expected/identity.out | 6 ++++--
src/test/regress/sql/identity.sql | 4 +++-
2 files changed, 7 insertions(+), 3 deletions(-)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-committers@postgresql.org
Cc: alvherre@alvh.no-ip.org, pgsql-committers@lists.postgresql.org
Subject: Re: pgsql: Fix test case to do what it intends to
In-Reply-To: <E1s6R9K-000jVs-Kz@gemulon.postgresql.org>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox