From: Alexander Korotkov <akorotkov@postgresql.org>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: Fix regression tests conflict in 3ca43dbbb6
Date: Mon, 13 May 2024 10:35:14 +0000
Message-ID: <E1s6T1U-000kgs-SD@gemulon.postgresql.org> (raw)
Fix regression tests conflict in 3ca43dbbb6
3ca43dbbb6 adds regression tests with permission checks. The conflict has
been observed at buildfarm member piculet.
This commit fixes the conflict in the following way.
1. partition_split.sql now uses role names regress_partition_split_alice and
regress_partition_split_bob (it mistakenly used
regress_partition_merge_alice and regress_partition_merge_bob before).
2. Permissions on schemas partitions_merge_schema and partition_split_schema
are granted to corresponding roles. Before, the lack of permissions led to
the creation of objects in the public schema and potential conflict.
Reported-by: Daniel Gustafsson
Discussion: https://postgr.es/m/03A07EF6-98D2-419B-A3AA-A111C64CC207%40yesql.se
Branch
------
master
Details
-------
https://git.postgresql.org/pg/commitdiff/2a679ae94e46ea2fa1ff5461c9d0767faecc6c8c
Modified Files
--------------
src/test/regress/expected/partition_merge.out | 4 ++++
src/test/regress/expected/partition_split.out | 25 +++++++++++++++----------
src/test/regress/sql/partition_merge.sql | 4 ++++
src/test/regress/sql/partition_split.sql | 25 +++++++++++++++----------
4 files changed, 38 insertions(+), 20 deletions(-)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-committers@postgresql.org
Cc: akorotkov@postgresql.org, pgsql-committers@lists.postgresql.org
Subject: Re: pgsql: Fix regression tests conflict in 3ca43dbbb6
In-Reply-To: <E1s6T1U-000kgs-SD@gemulon.postgresql.org>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox