From: Peter Eisentraut <peter@eisentraut.org>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: Remove unused typedefs
Date: Fri, 17 May 2024 05:40:03 +0000
Message-ID: <E1s7qK3-000aYG-LV@gemulon.postgresql.org> (raw)
Remove unused typedefs
There were a few typedefs that were never used to define a variable or
field. This had the effect that the buildfarm's typedefs.list would
not include them, and so they would need to be re-added manually to
keep the overall pgindent result perfectly clean.
We can easily get rid of these typedefs to avoid the issue. In a few
cases, we just let the enum or struct stand on its own without a
typedef around it. In one case, an enum was abused to define flag
bits; that's better done with macro definitions.
This fixes all the remaining issues with missing entries in the
buildfarm's typedefs.list.
Reviewed-by: Tom Lane <tgl@sss.pgh.pa.us>
Discussion: https://www.postgresql.org/message-id/1919000.1715815925@sss.pgh.pa.us
Branch
------
master
Details
-------
https://git.postgresql.org/pg/commitdiff/be5942aee7a012ce7f30bc7a6617903127f29e89
Modified Files
--------------
src/backend/commands/async.c | 6 +++---
src/backend/utils/resowner/resowner.c | 6 +++---
src/include/access/xlog.h | 4 ++--
src/include/storage/bufmgr.h | 12 ++++--------
src/tools/pgindent/typedefs.list | 4 ----
5 files changed, 12 insertions(+), 20 deletions(-)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-committers@postgresql.org
Cc: peter@eisentraut.org, pgsql-committers@lists.postgresql.org
Subject: Re: pgsql: Remove unused typedefs
In-Reply-To: <E1s7qK3-000aYG-LV@gemulon.postgresql.org>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox