pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Tom Lane <tgl@sss.pgh.pa.us>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: Add test case showing that commit d0d44049d fixed a live bug.
Date: Sat, 18 May 2024 18:26:28 +0000
Message-ID: <E1s8OlI-000plh-Rg@gemulon.postgresql.org> (raw)

Add test case showing that commit d0d44049d fixed a live bug.

When I committed d0d44049d (Account for optimized MinMax aggregates
during SS_finalize_plan), I didn't have a test case showing that it
was fixing any reachable bug.  Here is one, based on bug #18465 from
Hal Takahara.  Without the fix, all rows of the result show the same
"min" value, because the aggregate doesn't get recalculated.

Committed despite beta1 release freeze, with the concurrence of
pgsql-release.

Discussion: https://postgr.es/m/18465-2fae927718976b22@postgresql.org
Discussion: https://postgr.es/m/2391880.1689025003@sss.pgh.pa.us

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/779ac2c74bd15744aa92b588f70606a1a95256d2

Modified Files
--------------
src/test/regress/expected/aggregates.out | 31 +++++++++++++++++++++++++++++++
src/test/regress/sql/aggregates.sql      | 10 ++++++++++
2 files changed, 41 insertions(+)



Message-ID: <E1s8OlI-000plh-Rg@gemulon.postgresql.org>
Permalink:  ../E1s8OlI-000plh-Rg@gemulon.postgresql.org/
Also on:    postgresql.org/message-id/E1s8OlI-000plh-Rg@gemulon.postgresql.org

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-committers@postgresql.org
  Cc: tgl@sss.pgh.pa.us, pgsql-committers@lists.postgresql.org
  Subject: Re: pgsql: Add test case showing that commit d0d44049d fixed a live bug.
  In-Reply-To: <E1s8OlI-000plh-Rg@gemulon.postgresql.org>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox