pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Peter Eisentraut <peter@eisentraut.org>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: meson: Restore implicit warning/debug/optimize flags for extensi
Date: Fri, 07 Jun 2024 07:37:00 +0000
Message-ID: <E1sFU9j-000NZT-Bp@gemulon.postgresql.org> (raw)

meson: Restore implicit warning/debug/optimize flags for extensions

Meson uses warning/debug/optimize flags such as "-Wall", "-g", and
"-O2" automatically based on "--warnlevel" and "--buildtype" options.
And we use "--warning_level=1" and "--buildtype=debugoptimized" by
default.

But we need these flags for Makefile.global (for extensions) and
pg_config, so we need to compute them manually based on the
higher-level options.

Without this change, extensions building using pgxs wouldn't get -Wall
or optimization options.

Author: Sutou Kouhei <kou@clear-code.com>
Discussion: https://www.postgresql.org/message-id/flat/20240122.141139.931086145628347157.kou%40clear-code.com

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/3482bab5e30a0cc7fba4c904ba21b4957b2876bd

Modified Files
--------------
meson.build             | 32 ++++++++++++++++++++++++++++++++
src/include/meson.build |  4 ++--
2 files changed, 34 insertions(+), 2 deletions(-)



Message-ID: <E1sFU9j-000NZT-Bp@gemulon.postgresql.org>
Permalink:  ../E1sFU9j-000NZT-Bp@gemulon.postgresql.org/
Also on:    postgresql.org/message-id/E1sFU9j-000NZT-Bp@gemulon.postgresql.org

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-committers@postgresql.org
  Cc: peter@eisentraut.org, pgsql-committers@lists.postgresql.org
  Subject: Re: pgsql: meson: Restore implicit warning/debug/optimize flags for extensi
  In-Reply-To: <E1sFU9j-000NZT-Bp@gemulon.postgresql.org>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox