From: Peter Eisentraut <peter@eisentraut.org>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: pg_createsubscriber: Only --recovery-timeout controls the end of
Date: Mon, 17 Jun 2024 07:59:22 +0000
Message-ID: <E1sJ7Gs-001rTT-2O@gemulon.postgresql.org> (raw)
pg_createsubscriber: Only --recovery-timeout controls the end of recovery process
It used to check if the target server is connected to the primary
server (send required WAL) to rapidly react when the process won't
succeed. This code is not enough to guarantee that the recovery
process will complete. There is a window between the walreceiver
shutdown and the pg_is_in_recovery() returns false that can reach
NUM_CONN_ATTEMPTS attempts and fails.
Instead, rely only on the --recovery-timeout option to give up the
process after the specified number of seconds.
This should help with buildfarm failures on slow machines.
Author: Euler Taveira <euler.taveira@enterprisedb.com>
Reviewed-by: Hayato Kuroda <kuroda.hayato@fujitsu.com>
Discussion: https://www.postgresql.org/message-id/776c5cac-5ef5-4001-b1bc-5b698bc0c62a%40app.fastmail.com
Branch
------
master
Details
-------
https://git.postgresql.org/pg/commitdiff/04c8634c0c4d636540c9283efdd695558403dc4e
Modified Files
--------------
doc/src/sgml/ref/pg_createsubscriber.sgml | 7 ------
src/bin/pg_basebackup/pg_createsubscriber.c | 29 +++-------------------
src/bin/pg_basebackup/t/040_pg_createsubscriber.pl | 2 ++
3 files changed, 5 insertions(+), 33 deletions(-)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-committers@postgresql.org
Cc: peter@eisentraut.org, pgsql-committers@lists.postgresql.org
Subject: Re: pgsql: pg_createsubscriber: Only --recovery-timeout controls the end of
In-Reply-To: <E1sJ7Gs-001rTT-2O@gemulon.postgresql.org>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox