pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Peter Eisentraut <peter@eisentraut.org>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: pg_createsubscriber: Remove replication slot check on primary
Date: Mon, 17 Jun 2024 08:55:03 +0000
Message-ID: <E1sJ88k-001rrw-J9@gemulon.postgresql.org> (raw)

pg_createsubscriber: Remove replication slot check on primary

It used to check if the replication slot exists and is active on
primary.  This check might fail on slow hosts because the replication
slot might not be active at the time of this check.

The current code obtains the replication slot name from the
primary_slot_name on standby and assumes the replication slot exists
and is active on primary.  If it doesn't exist, this tool will log an
error and continue.

Author: Euler Taveira <euler.taveira@enterprisedb.com>
Reviewed-by: Hayato Kuroda <kuroda.hayato@fujitsu.com>
Discussion: https://www.postgresql.org/message-id/776c5cac-5ef5-4001-b1bc-5b698bc0c62a%40app.fastmail.com

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/b96391382626306c301b67cbd2d28313d96741f3

Modified Files
--------------
src/bin/pg_basebackup/pg_createsubscriber.c | 48 +----------------------------
1 file changed, 1 insertion(+), 47 deletions(-)



Message-ID: <E1sJ88k-001rrw-J9@gemulon.postgresql.org>
Permalink:  ../E1sJ88k-001rrw-J9@gemulon.postgresql.org/
Also on:    postgresql.org/message-id/E1sJ88k-001rrw-J9@gemulon.postgresql.org

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-committers@postgresql.org
  Cc: peter@eisentraut.org, pgsql-committers@lists.postgresql.org
  Subject: Re: pgsql: pg_createsubscriber: Remove replication slot check on primary
  In-Reply-To: <E1sJ88k-001rrw-J9@gemulon.postgresql.org>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox