pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Tom Lane <tgl@sss.pgh.pa.us>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: Remove recordExtensionInitPriv[Worker]'s ownerId argument.
Date: Mon, 17 Jun 2024 17:01:02 +0000
Message-ID: <E1sJFj3-001uaB-LQ@gemulon.postgresql.org> (raw)

Remove recordExtensionInitPriv[Worker]'s ownerId argument.

In the wake of the previous commit, we're not doing anything
with that argument.  Hence, revert the portions of 534287403
that added that argument and taught the callers to pass it.
Passing the ownerId requires additional syscache lookups in
some code paths, which'd be fine if we were doing anything
useful with the info, but it seems inadvisable if we're not.

Committed separately since there's some thought that we might
want to un-revert this in future, in case it's decided that
storing the original owner ID explicitly in pg_init_privs
is worth doing.

Discussion: https://postgr.es/m/CAMT0RQSVgv48G5GArUvOVhottWqZLrvC5wBzBa4HrUdXe9VRXw@mail.gmail.com

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/ba26d156636c84a9674e49dbdfe788b6291985f2

Modified Files
--------------
src/backend/catalog/aclchk.c | 71 +++++++++-----------------------------------
1 file changed, 14 insertions(+), 57 deletions(-)



Message-ID: <E1sJFj3-001uaB-LQ@gemulon.postgresql.org>
Permalink:  ../E1sJFj3-001uaB-LQ@gemulon.postgresql.org/
Also on:    postgresql.org/message-id/E1sJFj3-001uaB-LQ@gemulon.postgresql.org

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-committers@postgresql.org
  Cc: tgl@sss.pgh.pa.us, pgsql-committers@lists.postgresql.org
  Subject: Re: pgsql: Remove recordExtensionInitPriv[Worker]'s ownerId argument.
  In-Reply-To: <E1sJFj3-001uaB-LQ@gemulon.postgresql.org>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox