From: Tom Lane <tgl@sss.pgh.pa.us>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: Make pg_createsubscriber more wary about quoting connection para
Date: Sun, 30 Jun 2024 17:45:31 +0000
Message-ID: <E1sNycE-003gh4-EE@gemulon.postgresql.org> (raw)
Make pg_createsubscriber more wary about quoting connection parameters.
The original coding here could fail with database names, user names,
etc that contain spaces or other special characters.
As partial test coverage, extend the 040_pg_createsubscriber.pl
test script so that it uses a generated database name containing
funny characters.
Hayato Kuroda (some mods by me), per complaint from Noah Misch
Discussion: https://postgr.es/m/20240623062157.97.nmisch@google.com
Branch
------
master
Details
-------
https://git.postgresql.org/pg/commitdiff/b3f5ccebd79d9c7b73f4e04611cdf31fdf87420b
Modified Files
--------------
src/bin/pg_basebackup/pg_createsubscriber.c | 53 ++++++----
src/bin/pg_basebackup/t/040_pg_createsubscriber.pl | 111 ++++++++++++---------
2 files changed, 96 insertions(+), 68 deletions(-)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-committers@postgresql.org
Cc: tgl@sss.pgh.pa.us, pgsql-committers@lists.postgresql.org
Subject: Re: pgsql: Make pg_createsubscriber more wary about quoting connection para
In-Reply-To: <E1sNycE-003gh4-EE@gemulon.postgresql.org>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox