From: Tom Lane <tgl@sss.pgh.pa.us>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: Make pg_createsubscriber warn if publisher has two-phase commit
Date: Sun, 30 Jun 2024 18:24:23 +0000
Message-ID: <E1sNzDq-003gsL-FR@gemulon.postgresql.org> (raw)
Make pg_createsubscriber warn if publisher has two-phase commit enabled.
pg_createsubscriber currently always sets up logical replication
with two-phase commit disabled. Improving that is not going to
happen for v17. In the meantime, document the deficiency, and
adjust pg_createsubscriber so that it will emit a warning if
the source installation has max_prepared_transactions > 0.
Hayato Kuroda (some mods by Amit Kapila and me), per complaint from
Noah Misch
Discussion: https://postgr.es/m/20240623062157.97.nmisch@google.com
Branch
------
master
Details
-------
https://git.postgresql.org/pg/commitdiff/917754557cc0002bb042341720a7ce18fe5b0a09
Modified Files
--------------
doc/src/sgml/ref/pg_createsubscriber.sgml | 11 ++++++++++
src/bin/pg_basebackup/pg_createsubscriber.c | 34 ++++++++++++++---------------
2 files changed, 28 insertions(+), 17 deletions(-)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-committers@postgresql.org
Cc: tgl@sss.pgh.pa.us, pgsql-committers@lists.postgresql.org
Subject: Re: pgsql: Make pg_createsubscriber warn if publisher has two-phase commit
In-Reply-To: <E1sNzDq-003gsL-FR@gemulon.postgresql.org>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox