pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
pgsql: Fix copy-paste mistake in PQcancelCreate
2+ messages / 1 participants
[nested] [flat]

* pgsql: Fix copy-paste mistake in PQcancelCreate
@ 2024-07-01 11:59 Alvaro Herrera <alvherre@alvh.no-ip.org>
  0 siblings, 0 replies; 2+ messages in thread

From: Alvaro Herrera @ 2024-07-01 11:59 UTC (permalink / raw)
  To: pgsql-committers@lists.postgresql.org

Fix copy-paste mistake in PQcancelCreate

When an OOM occurred, this function was incorrectly setting a status of
CONNECTION_BAD on the passed in PGconn instead of on the newly created
PGcancelConn.

Mistake introduced with 61461a300c1c.  Backpatch to 17.

Author: Jelte Fennema-Nio <postgres@jeltef.nl>
Reported-by: Noah Misch <noah@leadboat.com>
Discussion: https://postgr.es/m/20240630190040.26.nmisch@google.com

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/3497c87b05a6ba31e8d760591900d550b2ef98bc

Modified Files
--------------
src/interfaces/libpq/fe-cancel.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)



^ permalink  raw  reply  [nested|flat] 2+ messages in thread

* pgsql: Fix copy-paste mistake in PQcancelCreate
@ 2024-07-01 11:59 Alvaro Herrera <alvherre@alvh.no-ip.org>
  0 siblings, 0 replies; 2+ messages in thread

From: Alvaro Herrera @ 2024-07-01 11:59 UTC (permalink / raw)
  To: pgsql-committers@lists.postgresql.org

Fix copy-paste mistake in PQcancelCreate

When an OOM occurred, this function was incorrectly setting a status of
CONNECTION_BAD on the passed in PGconn instead of on the newly created
PGcancelConn.

Mistake introduced with 61461a300c1c.  Backpatch to 17.

Author: Jelte Fennema-Nio <postgres@jeltef.nl>
Reported-by: Noah Misch <noah@leadboat.com>
Discussion: https://postgr.es/m/20240630190040.26.nmisch@google.com

Branch
------
REL_17_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/6d2ac554911d874e4d0609f5b2c5f34a1226ee0c

Modified Files
--------------
src/interfaces/libpq/fe-cancel.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)



^ permalink  raw  reply  [nested|flat] 2+ messages in thread


end of thread, other threads:[~2024-07-01 11:59 UTC | newest]

Thread overview: 2+ messages (download: mbox mbox.gz follow: Atom feed)
-- links below jump to the message on this page --
2024-07-01 11:59 pgsql: Fix copy-paste mistake in PQcancelCreate Alvaro Herrera <alvherre@alvh.no-ip.org>
2024-07-01 11:59 pgsql: Fix copy-paste mistake in PQcancelCreate Alvaro Herrera <alvherre@alvh.no-ip.org>

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox