pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Alvaro Herrera <alvherre@alvh.no-ip.org>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: Fix copy-paste mistake in PQcancelCreate
Date: Mon, 01 Jul 2024 11:59:31 +0000
Message-ID: <E1sOFgw-003n0f-U6@gemulon.postgresql.org> (raw)

Fix copy-paste mistake in PQcancelCreate

When an OOM occurred, this function was incorrectly setting a status of
CONNECTION_BAD on the passed in PGconn instead of on the newly created
PGcancelConn.

Mistake introduced with 61461a300c1c.  Backpatch to 17.

Author: Jelte Fennema-Nio <postgres@jeltef.nl>
Reported-by: Noah Misch <noah@leadboat.com>
Discussion: https://postgr.es/m/20240630190040.26.nmisch@google.com

Branch
------
REL_17_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/6d2ac554911d874e4d0609f5b2c5f34a1226ee0c

Modified Files
--------------
src/interfaces/libpq/fe-cancel.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)



view thread (2+ messages)

Message-ID: <E1sOFgw-003n0f-U6@gemulon.postgresql.org>
Permalink:  ../E1sOFgw-003n0f-U6@gemulon.postgresql.org/
Also on:    postgresql.org/message-id/E1sOFgw-003n0f-U6@gemulon.postgresql.org

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-committers@postgresql.org
  Cc: alvherre@alvh.no-ip.org, pgsql-committers@lists.postgresql.org
  Subject: Re: pgsql: Fix copy-paste mistake in PQcancelCreate
  In-Reply-To: <E1sOFgw-003n0f-U6@gemulon.postgresql.org>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox