From: Nathan Bossart <nathan@postgresql.org>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: Add --no-sync to pg_upgrade's uses of pg_dump and pg_dumpall.
Date: Mon, 01 Jul 2024 15:20:33 +0000
Message-ID: <E1sOIpU-003o0N-8U@gemulon.postgresql.org> (raw)
Add --no-sync to pg_upgrade's uses of pg_dump and pg_dumpall.
There's no reason to ensure that the files pg_upgrade generates
with pg_dump and pg_dumpall have been written safely to disk. If
there is a crash during pg_upgrade, the upgrade must be restarted
from the beginning; dump files left behind by previous pg_upgrade
attempts cannot be reused.
Reviewed-by: Peter Eisentraut, Tom Lane, Michael Paquier, Daniel Gustafsson
Discussion: https://postgr.es/m/20240503171348.GA1731524%40nathanxps13
Branch
------
master
Details
-------
https://git.postgresql.org/pg/commitdiff/6e16b1e42003d811562d30b572ac3972238e2957
Modified Files
--------------
src/bin/pg_upgrade/dump.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-committers@postgresql.org
Cc: nathan@postgresql.org, pgsql-committers@lists.postgresql.org
Subject: Re: pgsql: Add --no-sync to pg_upgrade's uses of pg_dump and pg_dumpall.
In-Reply-To: <E1sOIpU-003o0N-8U@gemulon.postgresql.org>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox