pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Tom Lane <tgl@sss.pgh.pa.us>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: Use xmlAddChildList not xmlAddChild in XMLSERIALIZE.
Date: Sat, 06 Jul 2024 19:16:33 +0000
Message-ID: <E1sQAtd-000bHU-Al@gemulon.postgresql.org> (raw)

Use xmlAddChildList not xmlAddChild in XMLSERIALIZE.

It looks like we should have been doing this all along,
but we got away with the wrong coding until libxml2 2.13.0
tightened up xmlAddChild's behavior.

There is more stuff to be fixed to be compatible with 2.13.0,
and it will all need to be back-patched.  This is just a
trial commit to see if the buildfarm agrees that we can use
xmlAddChildList unconditionally.

Erik Wienhold, per report from Frank Streitzig.

Discussion: https://postgr.es/m/trinity-b0161630-d230-4598-9ebc-7a23acdb37cb-1720186432160@3c-app-gmx-bap25
Discussion: https://postgr.es/m/trinity-361ba18b-541a-4fe7-bc63-655ae3a7d599-1720259822452@3c-app-gmx-bs01

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/066e8ac6ea8bc2af79dc86273a09ba7c1a39f7fd

Modified Files
--------------
src/backend/utils/adt/xml.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)



Message-ID: <E1sQAtd-000bHU-Al@gemulon.postgresql.org>
Permalink:  ../E1sQAtd-000bHU-Al@gemulon.postgresql.org/
Also on:    postgresql.org/message-id/E1sQAtd-000bHU-Al@gemulon.postgresql.org

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-committers@postgresql.org
  Cc: tgl@sss.pgh.pa.us, pgsql-committers@lists.postgresql.org
  Subject: Re: pgsql: Use xmlAddChildList not xmlAddChild in XMLSERIALIZE.
  In-Reply-To: <E1sQAtd-000bHU-Al@gemulon.postgresql.org>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox